Repository navigation
fix(tests): stop the TipFloor regression shadowing its helper - #939
Merged
Merged
Conversation
`let floor = try #require(floor(for: ...))` resolves `floor` to the local being declared once #require expands, so Xcode 26.3 fails with "cannot call value of non-function type 'TipFloor'". That broke App vectors (build) in the vector gate on every run since #889. Rename the helper to statedFloor(for:).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cross-platform vector gate fails at
App vectors (build)on every run since #889:let floor = try #require(floor(for: ...))resolvesfloorinside the macro expansion to the local being declared, not thefloor(for:)helper. Xcode 26.3 on the runner rejects it. This renames the helper tostatedFloor(for:).The two most recent gate failures on main stopped earlier, at
Ed25519 vectors, with a SwiftPM "already exists in file system" error downloading the SharedCore 0.10.0 xcframework. That was transient: a rerun of run 36866371159 passed both package vector steps and failed only on this compile error.