Repository navigation
fix(tip): raise a DM fee floor to the regional minimum - #891
Merged
Merged
Conversation
This was referenced Sep 28, 2026
bmc08gt
added this pull request to stack #894
September 28, 2026 18:43
bmc08gt
force-pushed
the
fix/tip-floor-regional-minimum
branch
from
September 28, 2026 18:44
05dc101 to
6b0115c
Compare
TipFloor.toOpenDM returned the recipient's fee whenever it was positive, even below the regional tip minimum. Every tip carries that minimum, so a 100 JPY or 1000 NGN fee (about $0.65 and $0.76) states a floor the server always denies with "tip amount is below the minimum of 1 USD". A fee under the preset row's minimum now falls back to the preset. The fee is compared in the row's currency, the way meetsMinimum compares an entry; a fee that can't be converted keeps its own floor.
bmc08gt
force-pushed
the
fix/tip-floor-regional-minimum
branch
from
September 28, 2026 18:44
6b0115c to
fc4bb64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #889.
TipFloor.toOpenDMreturns the recipient's fee whenever it's positive, even when it's under the regional tip minimum. Every tip carries that minimum, so the Start Chatting sheet can state a floor the server always denies. In the Bugsnag sample for6a67781, one user sent $0.76 four times and got "tip amount is below the minimum of 1 USD" each time. The recipient's fee isn't logged, so which fee that was is unconfirmed.Two other sampled fees sit under $1: 100 JPY and 1000 NGN. Those senders were denied for the fee, which means the server checks the fee first. With #889 they'd send the full fee and hit the minimum instead, so the rounding fix alone doesn't get them through.
A fee under the preset row's minimum now falls back to
.preset. The fee is compared in the row's currency, which is the entry currency or the USD fallback, the same wayTipPresets.meetsMinimumjudges an entry. A fee that can't be converted keeps its own floor.TipFloorTestscovers a $0.50 fee against a $1 minimum, a CAD fee under the USD fallback row, and a fee at the minimum that stays the fee.The Android change is code-payments/code-android-app#1599.