Repository navigation
fix(profile): floor Minimum To Chat on the regional tip minimum - #892
Merged
Merged
Conversation
The screen floored the fee at 1 unit of the balance currency, a fraction of a cent in IDR, NGN or JMD. Those entries passed locally and came back from the server as invalidAmount, and the dialog then named the 1-unit floor the entry already cleared, so users retried the same amount (Bugsnag 6aac6bd). Judge the fee against TipFloor.systemMinimum with the entry currency's preset row, or the USD fallback, as the send flow does. A server rejection after that check passes no longer repeats a floor, and the failure log now carries the fee's currency and amount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimum To Chat floored the fee at 1 unit of the balance currency. In IDR, NGN or JMD that's a fraction of a cent, so the entry passed locally and the server rejected it with
invalidAmount(Bugsnag6aac6bd, 225 events from 39 users). The rejection dialog then named the 1-unit floor, which the entry already cleared, so users sent the same amount again. One JMD user was rejected 20 times in under two minutes.The screen now judges the fee against
TipFloor.systemMinimum, using the entry currency's tip-preset row or the USD fallback row. This is the floor the send flow applies, and the dialog uses its "X Minimum Tip" wording. With no presets or no rate, no local check runs and the server decides.If the server still returns
invalidAmountafter that check passes, its floor isn't the preset one. The dialog then says "Amount Too Low" instead of repeating a floor the entry already met.The
SetMinDmChatInitFeefailure log now includes the fee'scurrencyandamount, which the Bugsnag events were missing.The contract doesn't state this RPC's range. This assumes it's the tip-preset minimum, which is also what Android's
MinimumTipEntryViewModelfloors on. That still needs confirming with backend.Regression_6aac6bdf6293b02dff667d25covers a fee under its own currency's row, one at it, one judged against the USD fallback, and the no-presets/no-rate cases.Fees already saved below the minimum stay on their profiles. #891 raises the sender's floor for those.