Repository navigation
feat(profile): drop the pinned footer when opened from the chat - #1027
Merged
Merged
Conversation
A profile opened from its own chat pinned Open Chat, which only returns to the screen underneath. From the chat, the group profile now hides Open Chat and puts Leave Chat in the scroll, and the user profile drops its bar when Open Chat was the pinned button, moving the e2ee footer into the scroll. Unblock and Start Chatting stay pinned. When the content fits, Leave Chat and the e2ee footer sit at the bottom of the screen with no fade. When it scrolls, the bottom fade and its clearance return. ProfileScrollFit decides which, and keeps the clearance from flipping it back once it's on. This matches code-android-app#1733, except Android blurs the bottom edge with Haze where iOS keeps the existing fade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A profile opened from its own chat pinned Open Chat, which only returns to the screen underneath.
Group profile, opened from its chat: Open Chat is hidden and Leave Chat moves into the scroll. Opened from a featured group, the pinned Open Chat + Leave Chat footer is unchanged.
User profile, opened from the DM: when Open Chat would have been the pinned button, the bar is gone and the e2ee footer moves into the scroll. Unblock and Start Chatting stay pinned.
Bottom edge: when the content fits, Leave Chat and the e2ee footer sit at the bottom of the screen with no fade. When it scrolls, the bottom fade and its 56pt clearance return.
ProfileScrollFitdecides which, and ignores the height the clearance itself takes so the fade doesn't flip back off once it's on. It has its own tests inProfileScrollFitTests.Matches code-payments/code-android-app#1733, except Android blurs the bottom edge with Haze where iOS keeps the existing fade. The system bottom scroll-edge effect didn't render behind an empty bar.