Repository navigation
feat(profile): fade a barless profile's bottom the way the chat does - #1029
Merged
Merged
Conversation
The barless profile used the pinned bar's fade: 56pt that turns mostly opaque early, over a solid block behind the home indicator. It now uses the chat's dissolve, which stays clear most of the way and reaches 90% only at the screen's bottom edge, so content under the home indicator still shows faintly. ChatFade moves the curve out of ComposerFadeView so both draw the same ramp. Profiles with a pinned button keep their own fade, which the button's text needs to stay readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1027. A profile opened from its chat pins no bar, but its bottom still used the pinned bar's fade: 56pt that turns mostly opaque early, over a solid block behind the home indicator.
It now uses the chat's dissolve from
ComposerFadeView, which stays clear most of the way and reaches 90% only at the screen's bottom edge, so content under the home indicator still shows faintly.ChatFademoves that curve out ofComposerFadeViewso both draw the same ramp.Profiles with a pinned button (Open Chat, Unblock, Start Chatting) keep their own fade, which the button's text needs to stay readable. The fade still appears only when the content scrolls.