Repository navigation
fix(profile): trim the group profile menu and set Report apart - #1000
Merged
Merged
Conversation
The group profile's ⋯ menu repeated what the screen already offers: Invite People does the same as Share → Share on Flipcash. The menu now holds Encryption (open lock, first), Mute Notifications for members, a divider, then Report as a red flag. Report is red and divided from the other entries in every menu that has it. The user profile menu gets a divider where the red entries start or stop. The message menu marks Report destructive, switches its icon to exclamationmark.bubble, and MessageMenuView draws a hairline before the first destructive row. The DM profile's encryption footer was unreadable over scrolled content, because the system scroll edge fade is too light for small text. Its pinned bar now draws the screen background with an eased 56pt fade above it, and the scroll content ends that much higher so the last row clears the fade. The group profile's Leave Chat sits 20pt lower: a text-only button is a full button tall, so the empty space under its title now overlaps the home indicator inset.
The message menu already uses exclamationmark.bubble, so Report now uses the same icon everywhere it appears.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The group profile's ⋯ menu repeated actions the screen already has. Invite People did the same thing as Share → Share on Flipcash, so it's gone. The menu now reads Encryption (open lock), Mute Notifications for members, a divider, then Report.
Report is red, uses
exclamationmark.bubble, and has a divider above it in all three menus that offer it:MessageMenuViewdraws a hairline before the first destructive row, andsize(for:)accounts for it.MessageCapabilityMenuTestsnow expects Report to be destructive.The DM profile's pinned encryption footer could not be read over scrolled content, because the system scroll edge fade is too light for 13pt text.
profilePinnedBackdrop()draws the screen background behind the bar with an eased 56pt fade above it, andprofilePinnedBackdropClearance()ends the scroll content that much higher so the last row clears the fade when scrolled to the bottom.On the group profile, the space below Leave Chat is 20pt tighter. A text-only button is a full button tall, so the empty space under its title now overlaps the home indicator inset.