Repository navigation
fix(messenger): use the speech-bubble icon for Report - #1697
Merged
Merged
Conversation
Swap Icons.Outlined.Flag for Icons.Outlined.Feedback on the message selection bar, the DM profile menu and the group profile menu, matching iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report now uses
Icons.Outlined.Feedback, the speech bubble with an exclamation mark, instead ofIcons.Outlined.Flag. This matches iOS, which uses the same bubble for Report on messages and both profiles (code-payments/code-ios-app#1000).The three places that used the flag:
ChatTopBar.kt: Report on the message selection barProfileMenuItems.kt:ReportUseron the user profileGroupProfileMenuItems.kt:ReportGroupon the group profileFeedbackcomes from material-icons-extended, which thecomposebundle already includes, so no dependency changes.Only the icon changes here. iOS also shows Report in red with a divider above it, but
MenuItem,ListItemandMenuListhave no destructive style or grouping yet, so that's left for a separate change.