Repository navigation
fix(profile): drop Open Chat when the profile was opened from that chat - #1733
Merged
Merged
Conversation
Back already returns to the chat, so the pinned Open Chat button only repeats it. Group profile opened from its chat: no pinned bar. Leave Chat moves to the end of the scroll and holds to the bottom when the page is short. Whether the chat is underneath is read once, because back pops the stack before the screen animates out and a live read brought the bar back for the exit. A group profile opened with nothing underneath keeps Open Chat and Leave Chat pinned. User profile: Open Chat is hidden only when the DM with that person is the chat underneath, so a member's portrait in a group still offers it. The encryption note now always sits in the scroll and holds to the bottom of a short page. With nothing pinned, the bottom edge gets the same progressive blur as the top (BottomScrollEdge).
github-actions
Bot
added
type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back already returns to the chat, so the pinned Open Chat button on a profile opened from that chat only repeats it.
Group profile, opened from its chat
heightIn(min = maxHeight)plus a weighted spacer).flowNavigator.canGoBack, read once withremember. Back pops the stack before the screen finishes animating out, so a live read brought the bar back during the exit.openOnProfile), it keeps Open Chat and Leave Chat pinned as before.User profile
opensChatUnderneathinProfilePinnedAction.kt, covered inProfileActionsTest). A member's portrait in a group still offers Open Chat, since that DM isn't the chat you came from.Bottom edge
BottomScrollEdgegives the bottom the same progressive blur asTopScrollEdge, and it clears once the scroll reaches the end.