Repository navigation
fix(messenger): head every group with its invite card - #1581
Merged
Merged
Conversation
A group with more than one member still opened on the old boxed ChatInfoCard; only a solo group got the invite card (node 10330:19164). The header now draws GroupInviteLinkCard for every group, with "Invite People" whenever the viewer is a member. A viewer who hasn't joined has no invite link to share, so their card has no button. GroupInviteLinkCard's ctaLabel is nullable to allow that: null leaves the button out and the card is as tall as its content. State.showsGroupInviteCard becomes offersGroupInvite, since it now decides the button rather than the card.
bmc08gt
force-pushed
the
fix/group-invite-card-design
branch
from
September 28, 2026 11:56
50305d4 to
6b8c7e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A group with more than one member opened on the old boxed
ChatInfoCard; only a solo group got the invite card (node10330:19164). The transcript header now drawsGroupInviteLinkCardfor every group, with "Invite People" whenever the viewer is a member.GroupInviteLinkCard.ctaLabelis nullable for this: null leaves the button out and the card sizes to its content.State.showsGroupInviteCardis nowoffersGroupInvite, because it decides the button, not the card.ChatViewModelStateTestcovers a solo group, a two-member group, a non-member, unknown membership and a DM.ChatInfoCard.