Repository navigation
fix(chat): head every group with its invite card - #885
Merged
Merged
Conversation
A group's transcript opened with the invite link card only while the viewer was its sole member. Once anyone else joined, the head fell back to the older bordered card, and the invite moved to the chat's profile. The head card is now the link card in every group. A member gets the "Invite People" button however many people have joined. Someone who hasn't joined has no link to hand out, so their card has no button and shrinks to its content. LinkGroupCardContent takes an optional CTA title for that case. The bordered card and the layout values only it used are gone. Android made the same change in code-payments/code-android-app#1581.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A group's transcript opened with the invite link card only while the viewer was its sole member (
ConversationScreen.showsGroupInvite). Once anyone else joined, the head fell back to the older bordered card, and the invite was only on the chat's profile.The head card is now the link card in every group:
LinkGroupCardContent.ctaTitleis now optional to allow the buttonless card. The bordered card inGroupCardView, and theLayoutvalues only it used, are removed. DM heads are unchanged.Android made the same change in code-payments/code-android-app#1581.