Skip to content

fix(tokens): don't gate Convert on holding a second currency #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Sep 27, 2026
Merged

fix(tokens): don't gate Convert on holding a second currency #1579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions apps/flipcash/shared/tokens/src/main/kotlin/com/flipcash/app/tokens/ui/TokenInfoViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,6 @@ class TokenInfoViewModel @Inject constructor(
/** Bounded per-token recent activity preview (newest first) for the v2 currency-info screen. */
val transactions: List<TransactionListItem> = emptyList(),
) {
val canSell: Boolean
get() = balance.underlyingTokenAmount.valueNonZero()

/** True when the user holds a displayable balance in some token other than [mint], which could fund a buy of it. */
val hasFundableBalance: Boolean
get() = fundableBalanceMints.any { it != mint }
Expand Down Expand Up @@ -331,23 +328,8 @@ class TokenInfoViewModel @Inject constructor(
.filterIsInstance<Event.OnConvert>()
.onEach {
val mint = stateFlow.value.mint ?: return@onEach
// Converting spends this currency and lands in another, so it needs both a
// balance here and somewhere for it to go.
if (!stateFlow.value.canSell || !stateFlow.value.hasFundableBalance) {
BottomBarManager.showInfo(
title = resources.getString(R.string.title_noBalanceYet),
message = resources.getString(R.string.description_noBalanceYetToBuy),
actions = listOf(
BottomBarAction(
text = resources.getString(R.string.action_addMoney)
) {
dispatchEvent(Event.PresentDepositOptions)
},
),
showCancel = true,
)
return@onEach
}
// No gate, matching iOS: the tile only shows for a held currency, and the
// destination needs no balance of its own.

// Dollars is the default landing spot; when Dollars *is* the source the swap
// view model substitutes the user's largest other holding.
Expand Down
Loading