Repository navigation
fix(tokens): don't gate Convert on holding a second currency - #1579
Merged
Merged
Conversation
Tapping Convert on the currency info screen showed "No Balance Yet" unless the user also held a displayable balance in some other currency. A user with $11.04 of Moony and no USDF couldn't convert it. Converting only spends the source currency; SwapViewModel resolves a destination the user doesn't hold through its token metadata. iOS opens the Convert flow without a check, and both platforms already show the tile only for a held currency, so drop the check. canSell had no other caller and goes with it.
github-actions
Bot
added
type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping Convert on a currency's info screen showed "No Balance Yet" unless the user also held a displayable balance in some other currency. A user reported it with $11.04 of Moony and no USDF: every tap brought up the Add Money sheet, and their log shows the sheet each time.
The check reused
hasFundableBalancefrom the Buy path, which asks whether another currency could pay for this one. Convert doesn't need that. It spends the source currency, andSwapViewModelresolves a destination the user doesn't hold throughgetTokenMetadata.iOS opens the Convert flow without a check (
CurrencyInfoScreen.swift,onConvert: { router.push(.convertCurrency(mint)) }). Both platforms already show the Convert tile only for a held currency, so this drops the Android check to match.State.canSellhad no other caller and is removed with it.