Skip to content

fix(chat): ask for the group name instead of labelling the screen #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Sep 22, 2026
Merged

fix(chat): ask for the group name instead of labelling the screen #1528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions apps/flipcash/core/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,9 +1053,10 @@
<!-- Each edit screen's own title. The row above says what it changes; this says what to do.
They are placed differently because the account flow places them differently for the same
two edits: PhotoSelectionScreen titles its app bar, NameEntryScreen leaves the bar bare and
heads the field itself. -->
heads the field itself. The name screen also borrows that screen's phrasing — it heads a
focused field, so it asks for the value the way title_profileNameSelection does. -->
<string name="title_setGroupPicture">Set Picture</string>
<string name="title_setGroupName">Set Name</string>
<string name="title_setGroupName">What\'s the group name?</string>

<!-- Both edits are confirmed before the call: a rename or a new picture is visible to the whole
group, so Save opens the prompt and the prompt's action is what sends it. -->
Expand All @@ -1065,8 +1066,6 @@
<string name="prompt_title_changeGroupPicture">Change Group Picture?</string>
<string name="prompt_description_changeGroupPicture">This will change the group picture for everyone in it</string>
<string name="action_changeGroupPicture">Change Picture</string>
<!-- EditChat bounds the title at 1-64 characters, enforced before the call. -->
<string name="subtitle_groupNameLength">Up to 64 characters</string>
<!-- EditChat answered DENIED: canEdit was false, or stopped being true since the menu was drawn. -->
<string name="error_title_groupEditDenied">Can\'t Edit This Group</string>
<string name="error_description_groupEditDenied">You don\'t have permission to edit this group</string>
Expand Down
1 change: 0 additions & 1 deletion ...in/kotlin/com/flipcash/app/messenger/internal/screens/profile/edit/EditGroupNameScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ internal fun EditGroupNameScreen(chatViewModel: ChatViewModel) {
DisplayTextInput(
state = state.titleFieldState,
placeholder = stringResource(R.string.hint_groupName),
sublabel = stringResource(R.string.subtitle_groupNameLength),
modifier = Modifier
.fillMaxWidth()
.focusRequester(focusRequester),
Expand Down
Loading