Repository navigation
fix(chat): ask for the group name instead of labelling the screen - #1528
Merged
Merged
Conversation
EditGroupNameScreen headed its field "Set Name", which restates the row that opened it rather than asking for the value. NameEntryScreen is the same edit in the account flow and asks — "What's your name?" — and this screen already copies its layout, so it now copies the phrasing too. Drops the "Up to 64 characters" sublabel with it. The bound is still enforced in the view model before the EditChat call; it just no longer sits under the field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EditGroupNameScreenheaded its field Set Name, which restates the Name row that opened it rather than asking for the value.NameEntryScreenis the same edit in the account flow and asks — "What's your name?" — and this screen already copies its layout (bare app bar, heading inside the scaffold atfillMaxWidth(0.7f),textLarge). It now copies the phrasing: What's the group name?. The longer string wraps there the same way the account one does, so no layout change was needed.Also drops the "Up to 64 characters" sublabel under the field, and the now-unused
subtitle_groupNameLengthstring. The 1–64 bound is unchanged — still enforced in the view model before the EditChat call.