Repository navigation
chore(chat): retire the GroupChats flag - #1472
Merged
Merged
Conversation
Group chats reach the chat list unconditionally. The flag only ever filtered the list — sync was already unconditional — and it was unreachable outside internal builds: GroupChats inherited FeatureTrack.Internal, which the Labs screen hides without the beta override, over a default of false. So it gated nothing for anyone who was not staff, and staff are the only accounts the server places in a group today. Membership is server-assigned, so there is no client action to gate. When create, join and leave arrive they gate actions rather than visibility, which is a different flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group chats now reach the chat list unconditionally.
The flag had one consumer —
TipFlowViewModeldeciding whetherchatCoordinator.feed(...)includedChatType.GROUP. Sync was already unconditional, so it filtered the list and nothing else.It was also unreachable outside internal builds.
GroupChatsdid not overrideminTrack, so it inheritedFeatureTrack.Internal, andLabsScreenContentlists onlyProductionflags without the beta override. Withdefault = falseand flags held in DataStore rather than remote config, a production user could neither see the toggle nor have it turned on for them.That leaves nothing for it to gate: membership is server-assigned, and staff accounts in the staff test group are the only ones the server places in a group today. Create, join and leave will need a gate when they land, but that one gates actions rather than visibility, so it is a new flag rather than this one returning.
Removed: the
FeatureFlag.GroupChatsentry with its title and description, theflatMapLatestbranch inTipFlowViewModel(and thefeatureFlagsdependency, which had no other use), and two comments that justified unconditional syncing by pointing at the flag.