Repository navigation
chore(scanner): retire the ScanFromGallery flag - #1520
Merged
Merged
Conversation
The gallery button draws whenever no bill is up, for everyone. The flag defaulted to false and inherited FeatureTrack.Internal, so the feature only ever reached staff with the beta override — it was a rollout gate, and the rollout is the point of removing it. Dropping the observation also takes the scanner's only FeatureFlag reference, so `:apps:flipcash:shared:featureflags` leaves the module's build file with it. The `persistLogOut = true` the flag carried has no successor: the preference key stays in DataStore unread, the same as the other retired flags.
github-actions
Bot
added
area: scanner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gallery button in the scanner draws whenever no bill is up, for everyone.
The flag defaulted to false and inherited
FeatureTrack.Internal, which the Labsscreen hides without the beta override, so the feature only ever reached staff. It
was a rollout gate; shipping the rollout is what removes it.
Three deletions:
FeatureFlag.ScanFromGalleryand itstitle/messageentries.FeatureFlagEntriesis generated from
@FeatureFlagMarker, so it leaves the Labs list on its own.observe(..)flow inScannableContainer. The button's gate is nowjust
billState.bill == null, which is the modal-scrim guard, not a rollout one.:apps:flipcash:shared:featureflagsfrom the scanner module's build file — thatobservation was the module's only
FeatureFlagreference.The
persistLogOut = truethe flag carried has no successor. Its DataStore key staysbehind unread, the same as the other retired flags.
Follows the shape of #1472.