Skip to content

chore: remove remaining AFX recruitment banner - #131

Merged
zombieJ merged 2 commits into
masterfrom
codex/remove-package-hiring-ad
Oct 8, 2026
Merged

zombieJ merged 2 commits into
masterfrom
codex/remove-package-hiring-ad

Conversation

@elrrrrrrr

@elrrrrrrr elrrrrrrr commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Package detail pages still display the retired AFX recruitment banner after its removal from the homepage. The advertised department no longer exists.

Remove the remaining banner from package detail pages, delete the unused AdHire component and recruitment link, and clean up the obsolete homepage comment.

Also pin Vitest to 4.0.16 and declare the compatible Vite 7 peer dependency to unblock npm 10 dependency installation in CI and preview builds. The floating Vitest range now selects 4.1.11, whose peer graph reproducibly crashes npm 10 with edgesOut.

Validation:

  • npm 10.9.9 clean dependency installation passed with the fixed dependency graph.
  • Lint and production build passed locally.
  • All 53 tests passed using Vitest 4.0.16.
  • Confirmed no remaining references to AdHire, the recruitment URL, or the retired department in src.
  • Latest GitHub CI passed on Node.js 22 and 24.
  • Cloudflare Pages preview deployment passed.
  • Vercel preview deployment passed.

Copilot AI balanced review requested due to automatic review settings October 8, 2026 01:34
@vercel

vercel Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cnpmweb Ready Ready Preview Oct 8, 2026 4:07am UTC

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 53fe3985-d083-4316-b056-b7dcf0dc16dd
📥 Commits

Reviewing files that changed from the base of the PR and between 6c654f6 and 1dfc6e1.

📒 Files selected for processing (1)
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The AdHire component and its package page import and render were removed. The homepage recruitment comment was also removed. The package manifest adds Vite as a development dependency and pins Vitest to version 4.0.16.

Changes

AdHire removal

Layer / File(s) Summary
Remove banner and page references
src/components/AdHire.tsx, src/pages/package/[...slug]/index.tsx, src/pages/index.tsx
The AdHire component and its package page import and render were removed. The homepage comment about the AFX recruitment advertisement was also removed.

Development dependency update

Layer / File(s) Summary
Update Vite and Vitest versions
package.json
Vite was added as a development dependency. Vitest was pinned to version 4.0.16.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: zombiej

Merge Risk: ⚪ Minimal · up to 1dfc6

The retired recruitment banner is removed as intended. The dependency update has no established supported-Node or installation failure, so no actionable merge blocker is evidenced.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the remaining AFX recruitment banner.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Deploying cnpmweb with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1dfc6e1
Status: ✅  Deploy successful!
Preview URL: https://130bcee1.cnpmweb.pages.dev
Branch Preview URL: https://codex-remove-package-hiring.cnpmweb.pages.dev

View logs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The targeted cleanup is complete, and no obsolete references remain in src.

0 open findings

What changed in this PR

Removes the retired AFX recruitment banner and obsolete references.

Changes:

  • Removes the package-page banner.
  • Deletes the unused AdHire component.
  • Removes the obsolete homepage comment.
File Description
src/​pages/​package/​[...slug]/​index.tsx Removes AdHire usage and import.
src/​pages/​index.tsx Removes the obsolete comment.
src/​components/​AdHire.tsx Deletes the retired banner component.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Copilot AI balanced review requested due to automatic review settings October 8, 2026 04:01
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​vitest@​4.1.11 ⏵ 4.0.1698 +125 -7579 +198100
Updatednpm/​vite@​8.3.3 ⏵ 7.3.7981008297100

View full report

@socket-security

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Priority Alert  (click "▶" to expand/collapse) Action
Medium priority
Critical CVE: When Vitest UI server is listening, arbitrary file can be read and executed

CVE: GHSA-5xrq-8626-4rwp When Vitest UI server is listening, arbitrary file can be read and executed (CRITICAL)

Affected versions: >= 4.0.0 < 4.1.0; < 3.2.6

Patched version: 4.1.0

From: package.json → npm/vitest@4.0.16

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/vitest@4.0.16. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn

View full report

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The retired banner is fully removed and the dependency changes are consistent with the existing test configuration.

0 open findings

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@zombieJ
zombieJ merged commit 0786789 into master Oct 8, 2026
13 checks passed
@zombieJ
zombieJ deleted the codex/remove-package-hiring-ad branch October 8, 2026 06:43

This branch was successfully deployed

1 active deployment
Preview — 1dfc6e13 Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants