Skip to content

chore(no-ticket): confidently say service is up to date #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coillteoir merged 1 commit into from
Oct 14, 2026
Merged

chore(no-ticket): confidently say service is up to date #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions cloudsmith_cli/cli/commands/check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,4 @@ def service(ctx, opts):
click.secho("(up-to-date)", fg="green")

click.echo()
click.secho(
"The API library used by this CLI tool seems to be up-to-date.", fg="green"
)
click.secho("The API library used by this CLI tool is up-to-date.", fg="green")
5 changes: 2 additions & 3 deletions cloudsmith_cli/cli/tests/commands/test_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def test_check_service_command_output(
assert output[6] == (
f"The API library used by this CLI tool is built against service version: {api_binding_version}"
if api_binding_version < service_version
else "The API library used by this CLI tool seems to be up-to-date."
else "The API library used by this CLI tool is up-to-date."
)

@pytest.mark.integration
Expand All @@ -72,6 +72,5 @@ def test_check_service_command(self, runner, api_host):
output[6].startswith(
"The API library used by this CLI tool is built against service version:"
)
or output[6]
== "The API library used by this CLI tool seems to be up-to-date."
or output[6] == "The API library used by this CLI tool is up-to-date."
)
Loading