Repository navigation
chore(no-ticket): confidently say service is up to date - #483
Merged
coillteoir merged 1 commit intoOct 14, 2026
Merged
coillteoir merged 1 commit into
coillteoir merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The wording change is correctly implemented and covered by existing tests.
0 open findings
What changed in this PR
Clarifies the service-check output by removing uncertain wording.
Changes:
- Reports the API library as definitively up to date.
- Updates unit and integration test expectations.
| File | Description |
|---|---|
cloudsmith_cli/cli/commands/check.py |
Updates the status message. |
cloudsmith_cli/cli/tests/commands/test_check.py |
Aligns assertions with the new message. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
the CLI has to believe in itself
Contributor
Author
Revision history
Generated by jj-stack from this pull request's force-push history. |
coillteoir
force-pushed
the
jj-stack/chore-no-ticket-confidently-say-service-is-up-to-date-mmwovyvv
branch
from
October 14, 2026 10:20
60b73f1 to
3d93936
Compare
cloudsmith-iduffy
approved these changes
Oct 14, 2026
coillteoir
enabled auto-merge (squash)
October 14, 2026 10:21
coillteoir
deleted the
jj-stack/chore-no-ticket-confidently-say-service-is-up-to-date-mmwovyvv
branch
October 14, 2026 10:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the CLI has to believe in itself