feat(zone): port the gitlab zone bridge to server-nestjs by shikanime · Pull Request #2807 · cloud-pi-native/console

shikanime · 2026-10-01T13:10:15Z

Issues liées

💡 [REQUEST] - Porter le pont zone GitLab vers server-nestjs #2864
PR refactor(zone): migrer le module vers server-nestjs #2487 (base, zone migration)
Fil de review : refactor(zone): migrer le module vers server-nestjs #2487 (review)

Quel est le comportement actuel ?

Sans ce pont, le provisioning gitlab des zones cesse silencieusement à la bascule #2770 : plus de repo infra de zone.

Quel est le nouveau comportement ?

Porte le pont zone gitlab de plugins/gitlab vers server-nestjs (suite au fil #2487).

GitlabService : zone.upsert garantit le repo infra de la zone ; zone.delete le supprime (parité plugins/gitlab deleteZone, suppression définitive permanentlyRemove)
Factorise unlessNotFound depuis les 7 sites catch-404 gitbeaker existants
Parité comportementale avec plugins/gitlab/src/functions.ts:189

StephaneTrebel

🔴 blocking — GitHub indique mergeStateStatus=DIRTY : pr/zone-bridges ne peut pas être intégrée dans sa base empilée pr/zone-migration. La comparaison montre 9 commits d’avance et 44 de retard ; merci de rebaser pr/zone-bridges sur le HEAD courant de pr/zone-migration, de résoudre les conflits et de relancer la CI avant la revue fonctionnelle des ponts Keycloak/GitLab.

StephaneTrebel

La parité Keycloak/GitLab doit être couverte avant de pouvoir autoriser la bascule de routage des zones.

shikanime

Rebase sur main effectué et poussé (tête : d7f874ef, contenu inchangé : 15 fichiers, +153/−121 ; gates vertes : tsc, 145 tests unitaires ciblés, lint scoped — le seul écart lint de zone.service.spec.ts existe déjà sur main). Trois blocants et un import à corriger avant merge, en commentaires inline : chemin GitLab double-préfixé dans deleteInfraGroupRepo, ordre client/Vault dans syncZone, régression multi-chemins auditor liée à la suppression de parseGroupPaths. Point positif : la parité legacy est documentée dans le code (commentaires « ported from ») et argocdUrl est propagé proprement de ZoneEventPayload jusqu'aux specs e2e.

Design: the zone.upsert payload carried argocdUrl from the caller's in-memory zone object, so a replayed event (retry, future automatic reconciliation) could not resolve it. The payload now carries only durable ids and syncZone re-fetches the zone via getZoneById. Also factor the repeated gitbeaker 404-to-undefined try/catch into unlessNotFound (7 sites). Related: #2807 Co-authored-by: Automata <automata@shikanime.studio>

Ports the legacy plugins/gitlab zone handlers (infra group repo lifecycle) to the server-nestjs gitlab module: zone.upsert ensures the zone infra repository, zone.delete cleans it up. The zone event payload now carries only durable ids (id, slug): the keycloak ArgoCD OIDC client bridge was dropped along with the argocdUrl field, as provisioning that client is no longer needed. Also factors the repeated gitbeaker 404-to-undefined try/catch into unlessNotFound (7 sites). Related: #2807 Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: Id23a51a6fdcfdaf53fcb6dea545e222c6a6a6964

Obsoleted by subsequent pushes: all blocking findings from this round are fixed or moot at head 118a336 (see resolved review threads). Dismissed to clear the stale gate; re-review requested.

Ports the legacy plugins/gitlab zone handlers (infra group repo lifecycle) to the server-nestjs gitlab module: zone.upsert ensures the zone infra repository, zone.delete cleans it up. The zone event payload now carries only durable ids (id, slug): the keycloak ArgoCD OIDC client bridge was dropped along with the argocdUrl field, as provisioning that client is no longer needed. Also factors the repeated gitbeaker 404-to-undefined try/catch into unlessNotFound (7 sites). handleUpsertZone / handleDeleteZone are covered by gitlab.service.spec specs (success and KO plugin result on each event). Related: #2864 Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: Id23a51a6fdcfdaf53fcb6dea545e222c6a6a6964

cloud-pi-native-sonarqube · 2026-10-15T19:37:24Z

Quality Gate passed

Issues

Measures

Project ID: cloud-pi-native_console_AYsa46O31ebDtzs-pYyZ

View in SonarQube

shikanime requested a review from a team as a code owner October 1, 2026 13:10

github-actions Bot added the built label Oct 1, 2026

shikanime force-pushed the pr/zone-bridges branch from 04ca984 to 29c8576 Compare October 1, 2026 14:02

StephaneTrebel previously requested changes Oct 1, 2026

View reviewed changes

shikanime force-pushed the pr/zone-bridges branch from 29c8576 to 657bd58 Compare October 1, 2026 15:46

shikanime force-pushed the pr/zone-bridges branch from 657bd58 to 0c92386 Compare October 2, 2026 08:17

shikanime self-assigned this Oct 2, 2026

StephaneTrebel mentioned this pull request Oct 2, 2026

refactor(zone): migrer le module vers server-nestjs #2487

Merged

shikanime force-pushed the pr/zone-bridges branch from 0c92386 to b560dba Compare October 2, 2026 11:56

shikanime force-pushed the pr/zone-bridges branch 2 times, most recently from 1a514e2 to b57ef56 Compare October 2, 2026 12:15

shikanime requested a review from StephaneTrebel October 2, 2026 14:03

StephaneTrebel mentioned this pull request Oct 2, 2026

feat(nginx-strangler): router les zones vers server-nestjs #2770

Open

StephaneTrebel previously requested changes Oct 2, 2026

View reviewed changes

Comment thread apps/server-nestjs/src/modules/gitlab/gitlab.service.ts

shikanime force-pushed the pr/zone-bridges branch from 2db35c0 to 6fc5a83 Compare October 2, 2026 15:01

shikanime force-pushed the pr/zone-bridges branch from 6fc5a83 to a82504f Compare October 2, 2026 15:09

Base automatically changed from pr/zone-migration to main October 2, 2026 16:35

shikanime force-pushed the pr/zone-bridges branch from a82504f to 4ad859e Compare October 2, 2026 16:53

shikanime moved this to Hypotheses in Cloud Pi Native Oct 5, 2026

shikanime force-pushed the pr/zone-bridges branch from 4ad859e to d7f874e Compare October 7, 2026 09:54

shikanime commented Oct 7, 2026

View reviewed changes

shikanime force-pushed the pr/zone-bridges branch from 9ae0f11 to e1fd3f3 Compare October 9, 2026 15:00

shikanime force-pushed the pr/zone-bridges branch from e1fd3f3 to bb52132 Compare October 9, 2026 15:00

shikanime force-pushed the pr/zone-bridges branch from bb52132 to f2c0590 Compare October 12, 2026 12:51

shikanime changed the title ~~feat(zone): port keycloak and gitlab zone bridges to server-nestjs~~ feat(zone): port the gitlab zone bridge to server-nestjs Oct 12, 2026

shikanime force-pushed the pr/zone-bridges branch from f2c0590 to 8826af9 Compare October 12, 2026 13:01

shikanime force-pushed the pr/zone-bridges branch from 8826af9 to c9bc35e Compare October 12, 2026 13:31

shikanime changed the base branch from main to refactor/ensure-vocabulary October 12, 2026 13:32

shikanime added this pull request to stack #2850 October 12, 2026 14:11

Base automatically changed from refactor/ensure-vocabulary to main October 15, 2026 09:00

shikanime force-pushed the pr/zone-bridges branch from c9bc35e to 4f49791 Compare October 15, 2026 09:00

shikanime force-pushed the pr/zone-bridges branch 2 times, most recently from a0d70c4 to 9b5f0b1 Compare October 15, 2026 15:18

shikanime closed this Oct 15, 2026

shikanime deleted the pr/zone-bridges branch October 15, 2026 15:29

github-project-automation Bot moved this from In Progress to Done in Cloud Pi Native Oct 15, 2026

shikanime reopened this Oct 15, 2026

github-project-automation Bot moved this from Done to Refinement in Cloud Pi Native Oct 15, 2026

shikanime mentioned this pull request Oct 15, 2026

💡 [REQUEST] - Porter le pont zone GitLab vers server-nestjs #2864

Open

2 of 3 tasks

shikanime requested a review from StephaneTrebel October 15, 2026 16:06

shikanime force-pushed the pr/zone-bridges branch from 118a336 to d9c6b5b Compare October 15, 2026 19:31

Navigation Menu

Repository navigation

feat(zone): port the gitlab zone bridge to server-nestjs - #2807

feat(zone): port the gitlab zone bridge to server-nestjs#2807
shikanime wants to merge 1 commit into
mainfrom
pr/zone-bridges

shikanime commented Oct 1, 2026 •

edited

Loading

Uh oh!

StephaneTrebel left a comment

Uh oh!

StephaneTrebel left a comment

Uh oh!

Uh oh!

shikanime left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cloud-pi-native-sonarqube Bot commented Oct 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

shikanime commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues liées

Quel est le comportement actuel ?

Quel est le nouveau comportement ?

Uh oh!

StephaneTrebel left a comment

Choose a reason for hiding this comment

Uh oh!

StephaneTrebel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shikanime left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cloud-pi-native-sonarqube Bot commented Oct 15, 2026

Quality Gate passed

Issues

Measures

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shikanime commented Oct 1, 2026 •

edited

Loading