Skip to content

feat(nginx-strangler): router les zones vers server-nestjs - #2770

Open
shikanime wants to merge 1 commit into
mainfrom
pr/nginx-zone-routing
Open

feat(nginx-strangler): router les zones vers server-nestjs#2770
shikanime wants to merge 1 commit into
mainfrom
pr/nginx-zone-routing

Conversation

@shikanime

@shikanime shikanime commented Sep 23, 2026

Copy link
Copy Markdown
Member

Issues liées

Refs #2486

Quel est le comportement actuel ?

Le routage nginx des zones dépend de la PR du module zone (#2487).

Quel est le nouveau comportement ?

Ajout de la location /api/v1/zones dans apps/nginx-strangler/conf.d/routing.conf vers server-nestjs, extraite de #2487 pour revoir la bascule de routage indépendamment du code NestJS.

Cette PR introduit-elle un breaking change ?

Non.

Autres informations

@shikanime
shikanime requested a review from a team as a code owner September 23, 2026 13:16
@shikanime
shikanime changed the base branch from main to pr/zone-migration September 23, 2026 13:17
@shikanime shikanime mentioned this pull request Sep 23, 2026
Merged
@shikanime
shikanime force-pushed the pr/nginx-zone-routing branch from d9331d7 to e40276f Compare September 23, 2026 13:19
@github-actions github-actions Bot added the built label Sep 23, 2026
@shikanime
shikanime added this pull request to stack #2771 September 23, 2026 13:26
@shikanime
shikanime force-pushed the pr/nginx-zone-routing branch 2 times, most recently from 8a3c954 to 9dbab59 Compare September 23, 2026 13:54
@shikanime shikanime self-assigned this Sep 23, 2026
@shikanime shikanime added this to the 9.27.0 milestone Sep 23, 2026
@shikanime
shikanime force-pushed the pr/nginx-zone-routing branch from 9dbab59 to 4621eb8 Compare September 23, 2026 14:03
@shikanime shikanime added the preview Deploy preview app with Argo-cd label Sep 24, 2026
@github-actions

github-actions Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

A preview of the application is available at : https://console-pr-2770.dso.cpin-hp.numerique-interieur.fr

Please be patient, deployment may take a few minutes.

StephaneTrebel
StephaneTrebel previously approved these changes Sep 24, 2026
View reviewed changes
@shikanime shikanime removed the preview Deploy preview app with Argo-cd label Sep 28, 2026
@shikanime shikanime moved this to Backlog in Cloud Pi Native Sep 29, 2026
@shikanime shikanime moved this from Ready to In review in Cloud Pi Native Sep 29, 2026
@shikanime shikanime added the enhancement New feature or request label Sep 29, 2026
@shikanime
shikanime requested review from a team and StephaneTrebel and removed request for StephaneTrebel September 29, 2026 11:13
@shikanime shikanime mentioned this pull request Oct 1, 2026
Open
@shikanime
shikanime dismissed StephaneTrebel’s stale review October 1, 2026 14:49

The merge-base changed after approval.

@shikanime
shikanime force-pushed the pr/nginx-zone-routing branch from dabf67a to 80ae95b Compare October 2, 2026 11:56
@shikanime
shikanime force-pushed the pr/nginx-zone-routing branch 2 times, most recently from 14a9522 to 1288ca8 Compare October 2, 2026 12:15
shikanime
shikanime commented Oct 2, 2026
View reviewed changes

@shikanime shikanime left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict : Commentaire

Le DIRTY signalé le 01/10 est levé : la branche est MERGEABLE sur pr/zone-migration (BEHIND uniquement, retarget attendu de la pile). Diff minimal : la location /api/v1/zones (9 lignes) vers server-nestjs, même gabarit que les bascules déjà fusionnées, rollback documenté. CI verte (run 37005636176), scan de sécurité : néant.

✨ L'extraction de la bascule hors de #2487 découple la revue du cutover de celle du module — le bon plan de découpage pour un strangler.

@shikanime shikanime mentioned this pull request Oct 2, 2026
Merged
StephaneTrebel
StephaneTrebel reviewed Oct 2, 2026
View reviewed changes
Comment thread apps/nginx-strangler/conf.d/routing.conf
StephaneTrebel
StephaneTrebel requested changes Oct 2, 2026
View reviewed changes

@StephaneTrebel StephaneTrebel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La règle de routage est isolée correctement, mais elle expose le défaut bloquant encore ouvert dans sa base #2487 et ferait répondre 500 aux mutations de zone. Ledger #2486 : 1/3 ; la CI est verte et le fil bloquant restera ouvert jusqu’à l’intégration du correctif de la migration zone.

@shikanime
shikanime force-pushed the pr/nginx-zone-routing branch from 1288ca8 to 3f8c62a Compare October 2, 2026 13:00
StephaneTrebel
StephaneTrebel previously requested changes Oct 2, 2026
View reviewed changes

@StephaneTrebel StephaneTrebel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le défaut de journalisation de #2487 est corrigé, mais la parité des consommateurs de l’événement n’est pas encore livrée sur la branche cible.

Comment thread apps/nginx-strangler/conf.d/routing.conf
@shikanime
shikanime force-pushed the pr/nginx-zone-routing branch from 3f8c62a to 708033d Compare October 2, 2026 14:59
@shikanime
shikanime force-pushed the pr/nginx-zone-routing branch 3 times, most recently from 0c48362 to 7e94f85 Compare October 2, 2026 15:23
Base automatically changed from pr/zone-migration to main October 2, 2026 16:35
@shikanime
feat(nginx-strangler): router les zones vers server-nestjs
9168679 
Co-authored-by: Automata <automata@shikanime.studio>

Signed-off-by: Shikanime Deva <22115108+shikanime@users.noreply.github.com>
@shikanime
shikanime force-pushed the pr/nginx-zone-routing branch from 7e94f85 to d6af39e Compare October 2, 2026 16:53
@StephaneTrebel
StephaneTrebel requested a review from a team October 5, 2026 08:39
StephaneTrebel
StephaneTrebel requested changes Oct 5, 2026
View reviewed changes

@StephaneTrebel StephaneTrebel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking: le routage est correct et la CI est verte, mais le bridge Keycloak/GitLab #2807 reste ouvert avec des changements demandés. Le fil inline non résolu demeure donc pertinent : router les mutations de zone maintenant supprimerait les synchronisations legacy avant que leurs consommateurs NestJS soient livrés.

@shikanime shikanime modified the milestones: 9.27.0, 9.28.0 Oct 6, 2026
@shikanime
shikanime force-pushed the pr/nginx-zone-routing branch from d6af39e to 9168679 Compare October 8, 2026 12:25
@cloud-pi-native-sonarqube

cloud-pi-native-sonarqube Bot commented Oct 8, 2026

Copy link
Copy Markdown

Passed Quality Gate passed

Issues

Measures

Project ID: cloud-pi-native_console_AYsa46O31ebDtzs-pYyZ

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephaneTrebel StephaneTrebel StephaneTrebel requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@shikanime shikanime

Labels

built enhancement New feature or request

Projects

None yet

Milestone

9.28.0

Development

Successfully merging this pull request may close these issues.

2 participants

@shikanime @StephaneTrebel