Skip to content

test(expo): read the Platform API key from MOBILE_VERIFICATION_PLATFORM_API_KEY - #10616

Merged
mikepitre merged 2 commits into
mainfrom
mobile-verification-key-name
Nov 3, 2026
Merged

mikepitre merged 2 commits into
mainfrom
mobile-verification-key-name

Conversation

@mikepitre

@mikepitre mikepitre commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Description

The Expo native verify CLI read the team Platform API key from CLERK_PLATFORM_API_KEY, the same name this repo's web integration suite uses for its own key, in ci.yml, nightly-checks.yml and integration/presets/envs.ts. A shell set up for the web tests would point the mobile CLI at the wrong workspace. clerk/internal-mobile-e2e#10 renames the variables to match the MOBILE_VERIFICATION_PLATFORM_API_KEY secret.

This pins @clerk/internal-mobile-e2e to that commit (0889a2d). It renames the variable in verify-e2e.yml, the Expo host test, and the verify-clerk-expo skill to MOBILE_VERIFICATION_PLATFORM_API_KEY, MOBILE_VERIFICATION_PLATFORM_API_KEY_FILE, or MOBILE_VERIFICATION_PLATFORM_API_KEY_REFERENCE (was VERIFY_PLATFORM_KEY_REFERENCE). The web suite's CLERK_PLATFORM_API_KEY is unchanged. Merge clerk/internal-mobile-e2e#10 first.

npm ci and npm test in integration/expo-native: 181 pass.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

🤖 Generated with Claude Code

…RM_API_KEY

Pins @clerk/internal-mobile-e2e to b70b190, which renames the key variables
to MOBILE_VERIFICATION_PLATFORM_API_KEY, _FILE and _REFERENCE.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Nov 3, 2026 8:40pm UTC
swingset Ready Ready Preview Nov 3, 2026 8:40pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ccedac2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

Expo verification documentation, the environment test, and CI workflow steps now use the MOBILE_VERIFICATION_PLATFORM_API_KEY variable family. The internal mobile E2E dependency reference changes to a different commit. A changeset file with empty frontmatter is added.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • clerk/javascript#10596: Documents the Platform API credential used by the internal mobile E2E CLI, which is renamed in this PR.

Suggested reviewers: wobsoriano

Merge Risk: Minimal · up to cceda

The credential rename and dependency update have no identified merge-blocking issue.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: reading the Expo native verification Platform API key from MOBILE_VERIFICATION_PLATFORM_API_KEY.
Description check Passed The description directly explains the variable rename, dependency pin, affected files, reason for the change, and reported test results.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: clerk/javascript
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: f7a0b2d
  • Layers: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 672680b8-8603-4f55-a64e-c53ecba7fc95
Commits

Reviewing files that changed from the base of the PR and between 71881e5 and ccedac2.

Files ignored due to path filters: 1
  • integration/expo-native/package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 1
  • integration/expo-native/package.json
Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

@blacksmith-sh

blacksmith-sh Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Matches CLI reads key from MOBILE_VERIFICATION_PLATFORM_API_KEY

With the 0889a2d pin, doctor ignores a web-suite CLERK_PLATFORM_API_KEY and reports a key from each of the three MOBILE_VERIFICATION_PLATFORM_API_KEY variables. Before, it was the reverse.

Merge-base

Key sources before

This PR ccedac25

Key sources after

Also checked · 1 match

Matches Build step strips the renamed key variables

Proof on ccedac25 (from 71881e56) · Did Proof get it right? Yes · No

View full Proof report

@pkg-pr-new

pkg-pr-new Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10616

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10616

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10616

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10616

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10616

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10616

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10616

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10616

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10616

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10616

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10616

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10616

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10616

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10616

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10616

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10616

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10616

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10616

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10616

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10616

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10616

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10616

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10616

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10616

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10616

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10616

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10616

commit: ccedac2

It also keeps the old and web-suite key names out of child processes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mikepitre
mikepitre merged commit 7965f10 into main Nov 3, 2026
59 checks passed
@mikepitre
mikepitre deleted the mobile-verification-key-name branch November 3, 2026 20:50

This branch was successfully deployed

2 active deployments
Preview – swingset — ccedac25 Deployed Nov 3, 2026 by vercel[bot]
Preview – clerk-js-sandbox — ccedac25 Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants