Repository navigation
fix(instances): name the Platform API key variables for mobile verification - #10
Conversation
…cation CLERK_PLATFORM_API_KEY is the name clerk/javascript's web integration suite already uses for its own key, so a shell set up for those tests would point the mobile CLI at the wrong workspace. Rename the three ways to supply the key to match the MOBILE_VERIFICATION_PLATFORM_API_KEY secret: MOBILE_VERIFICATION_PLATFORM_API_KEY, _FILE and _REFERENCE (was VERIFY_PLATFORM_KEY_REFERENCE). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
… child processes The CLI reads only the MOBILE_VERIFICATION_ names, but a shell can still hold CLERK_PLATFORM_API_KEY for clerk/javascript's web suite, or the old names. Strip those from every child environment too, without reading them as the key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What & why
CLERK_PLATFORM_API_KEY. That's also the name clerk/javascript's web integration suite uses for a different key, so a shell set up for those tests would send the mobile CLI's throwaway apps to the wrong workspace.MOBILE_VERIFICATION_PLATFORM_API_KEYsecret that consumer CI already reads:MOBILE_VERIFICATION_PLATFORM_API_KEY,MOBILE_VERIFICATION_PLATFORM_API_KEY_FILE, andMOBILE_VERIFICATION_PLATFORM_API_KEY_REFERENCE(wasVERIFY_PLATFORM_KEY_REFERENCE). No fallback to the old names.Testing
npm run build, thennode --test test/*.test.ts: 736 pass.tsc -p .is clean.Risk
KEYS_MISSINGuntil they rename them. The error's fix line names the new variables.How to revert
🤖 Generated with Claude Code