Skip to content

fix(backend): correct salted password digests and accept every documented hasher #10504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manovotny wants to merge 3 commits into
base: main
Choose a base branch
from
+15 −4
Open

fix(backend): correct salted password digests and accept every documented hasher #10504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ef9dd6
docs(backend): correct the salted password digest order in createUser…
manovotny Oct 28, 2026
9d535e9
docs(backend): describe the digest fix for people upgrading
manovotny Oct 28, 2026
9f1148d
fix(backend): accept every documented hasher in PasswordHasher
manovotny Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-salted-password-digest-order.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/backend': patch
---

Add `bcrypt_peppered`, `md5_salted`, `pbkdf2_sha512`, `pbkdf2_sha512_hex`, `sha256_salted`, and `sha512_symfony` to the `PasswordHasher` type, so TypeScript accepts every hasher the `createUser()` JSDoc documents. The JSDoc for `md5_salted` and `sha256_salted` now also shows the `password_digest` format the Backend API accepts: `hash$salt`, not `salt$hash`.
14 changes: 10 additions & 4 deletions packages/backend/src/api/endpoints/UserApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,15 +101,21 @@ export type PasswordHasher =
| 'argon2id'
| 'awscognito'
| 'bcrypt'
| 'bcrypt_peppered'
| 'bcrypt_sha256_django'
| 'md5'
| 'md5_salted'
| 'pbkdf2_sha256'
| 'pbkdf2_sha256_django'
| 'pbkdf2_sha1'
| 'pbkdf2_sha512'
| 'pbkdf2_sha512_hex'
| 'phpass'
| 'scrypt_firebase'
| 'scrypt_werkzeug'
| 'sha256'
| 'sha256_salted'
| 'sha512_symfony'
| 'md5_phpass'
| 'ldap_ssha';

Expand Down Expand Up @@ -145,9 +151,9 @@ export type UserPasswordHashingParams = {
* </ul>
* <li> [`md5_salted` (insecure)](https://en.wikipedia.org/wiki/MD5) </li>
* <ul>
* <li> When set, `password_digest` must be in the format of `salt$hash`. </li>
* <li> _salt:_ The salt used to generate the above hash. </li>
* <li> When set, `password_digest` must be in the format of `hash$salt`. </li>
* <li> _hash:_ A 32-length hex string. </li>
* <li> _salt:_ The salt used to generate the above hash. </li>
Comment thread
coderabbitai[bot] marked this conversation as resolved.
* </ul>
* <li> [`pbkdf2_sha1`](https://en.wikipedia.org/wiki/PBKDF2) </li>
* <ul>
Expand Down Expand Up @@ -205,9 +211,9 @@ export type UserPasswordHashingParams = {
* </ul>
* <li> [`sha256_salted` (insecure)](https://en.wikipedia.org/wiki/SHA-2) </li>
* <ul>
* <li> When set, `password_digest` must be in the format of `salt$hash`. </li>
* <li> _salt:_ The salt used to generate the above hash. </li>
* <li> When set, `password_digest` must be in the format of `hash$salt`. </li>
* <li> _hash:_ A 64-length hex string. </li>
* <li> _salt:_ The salt used to generate the above hash. </li>
* </ul>
* <li> [`argon2`](https://argon2.online/) variants: `argon2i` and `argon2id`. </li>
* <ul>
Expand Down
Loading