Skip to content

feat(mosaic): hold the connected account menu open while reconnect starts - #10445

Closed
austincalvelage wants to merge 1 commit into
austin/mfa-backup-codes-pending-menufrom
austin/connected-accounts-reconnect-pending
Closed

austincalvelage wants to merge 1 commit into
austin/mfa-backup-codes-pending-menufrom
austin/connected-accounts-reconnect-pending

Conversation

@austincalvelage

Copy link
Copy Markdown
Member

Description

Stacked on #10436.

On a slow connection, choosing Reconnect (or Try again) on a connected account used to close the menu right away, and nothing showed until the browser left for the provider.

Now the menu stays open while the reconnect starts:

  • Reconnect shows a spinner and is marked busy, and the menu's other actions are disabled.
  • Escape and clicking outside don't close the menu while it's pending.
  • The menu closes as soon as the session verification card opens, or when the redirect to the provider starts.
  • Failures close the menu and show in the row's existing error.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 27, 2026 2:42am UTC
swingset Ready Ready Preview Oct 27, 2026 2:42am UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 44e7549

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@austincalvelage

Copy link
Copy Markdown
Member Author

Dropping this. Reconnect ends with the page leaving, so holding the menu open reads as stuck on fast connections. The menu keeps closing on click.

This branch was successfully deployed

2 active deployments
Preview – swingset — 44e7549b Deployed Oct 27, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 44e7549b Deployed Oct 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant