Repository navigation
refactor(mosaic): share reading direction and text entry helpers across primitives - #10419
Closed
alexcarpenter wants to merge 1 commit into
Closed
alexcarpenter wants to merge 1 commit into
alexcarpenter wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: a5f817a The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
alexcarpenter
force-pushed
the
carp/mosaic-shared-dom-helpers
branch
from
October 25, 2026 21:57
904a00a to
ebdb3c8
Compare
1 of 9 tasks
alexcarpenter
force-pushed
the
carp/mosaic-shared-dom-helpers
branch
from
October 25, 2026 23:04
ebdb3c8 to
fef0833
Compare
alexcarpenter
force-pushed
the
carp/mosaic-shared-dom-helpers
branch
from
October 25, 2026 23:05
fef0833 to
ef4d59a
Compare
alexcarpenter
force-pushed
the
carp/mosaic-shared-dom-helpers
branch
from
October 25, 2026 23:10
ef4d59a to
8ef5742
Compare
alexcarpenter
force-pushed
the
carp/mosaic-shared-dom-helpers
branch
from
October 25, 2026 23:16
8ef5742 to
cfdc5a7
Compare
alexcarpenter
force-pushed
the
carp/mosaic-shared-dom-helpers
branch
from
October 25, 2026 23:22
cfdc5a7 to
a5f817a
Compare
2 of 9 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #10414.
Moves two DOM helpers that several primitives each wrote locally into
primitives/utils/dom.ts:readingDirectionKeys(element)returns the previous and next arrow keys for the element's reading direction, found from the nearestdirancestor. Table (row expand/collapse and grid navigation), Tag Input and OTP now use it. It replaces the copy intag-input-utils.ts, the inline block inotp-input.tsxand the table'sisRtl.opensKeyboardplus<select>, so it no longer has its own selector.One change in behavior, only in the unreleased table: it used to read the computed CSS
direction, and now it reads thedirattribute like Tag Input and OTP do.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change