Repository navigation
Add ping tool as a separately-releasable application module - #1
Merged
Merged
Conversation
ping lives under tools/ping as its own Application-type DMOD module, built on dmicmp's existing Echo Request/Reply API (dmicmp_v4_send_echo_request(), dmicmp_register_echo_listener()). Like dmnet's tools/ifconfig, it gets its own CMakeLists.txt + .dmr, so every tagged release packages ping-<tag>-<arch>.zip alongside dmicmp itself. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V4i6Vs6fjG9cdHGj3AMpD5
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ping, a CLI to send ICMPv4 Echo Requests and report replies, undertools/ping- a command indmicmp's newtools/directory, following the same patterndmnet/tools/ifconfiganddmnet/tools/ipalready use in the ecosystem.pingis its own Application-type DMOD module (ownCMakeLists.txt+ping.dmr), so every tagged release of this repo now also packagesping-<tag>-<arch>.zipalongsidedmicmpitself - no change to.github/workflows/release.ymlwas needed, since it already discovers and packages every module underbuild/packages/*.pingis a thin CLI overdmicmp's existing Echo Request/Reply API (dmicmp_v4_send_echo_request(),dmicmp_register_echo_listener()/_unregister_echo_listener()) - it builds/parses no ICMP bytes itself. It linksdmicmp's owndmicmp_iftarget directly (a same-repo sibling module, liketests/CMakeLists.txtalready does) rather than fetchingdmicmp's headers back from GitHub as if it were external.-c <count>,-i <interval_ms>,-W <timeout_ms>,-s <size>, and requires a literal IPv4 address (no hostname resolution, no ICMPv6 send path yet - same limitationdmicmpitself documents).tools/ping/tests/ping_test.c, driven throughDmod_RunModule("ping", ...)the same wayifconfig_test.cdrivesifconfig, plusdocs/and aREADME.mdfor the new module.Test plan
cmakeconfigure succeeds with a localdmodcheckout and correctly wires theping/test_pingtargets (verified locally; this sandbox has nodmf-get/network access to run a full build orctest, same as CI's containerized build)tools/ping/src/ping.candtools/ping/tests/ping_test.ccompile cleanly (gcc -fsyntax-only -Wall -Wextra) against the realdmicmp/dmip/dmroute/dmnetif/dmarp/dmosiheaders from their published repos.github/workflows/ci.yml) buildsdmicmp+pingand runstest_dmicmp/test_pingviadmod_loader🤖 Generated with Claude Code
https://claude.ai/code/session_01V4i6Vs6fjG9cdHGj3AMpD5
Generated by Claude Code