Repository navigation
Register dmicmp as a service directly via libsystemd's new type=library - #3
Merged
Merged
Conversation
dmsystem's libsystemd now supports type=module units, which load+enable (instead of spawn) a Library-type module directly. This removes the need for icmp-start.dme/icmp-stop.dme, the dmell scripts that used to wrap "module load"/"module enable"/"module unload" for icmp.ini's exec=dmell launcher. icmp.ini now just says "exec=dmicmp" + "type=module" directly, and "service stop icmp" actually works now (it used to have nothing to act on, since the old type=oneshot unit's process was already gone by the time it would run). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JibXp8rSB2Bp1DKtnQhxaQ
…enamed unit type dmsystem's libsystemd renamed its "module" unit type to "library" (see choco-technologies/dmsystem#2) - "module" was ambiguous since an Application is a DMOD module too. Update icmp.ini and docs to match before this PR merges. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JibXp8rSB2Bp1DKtnQhxaQ
JohnAmadis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type=moduletotype=library; originally built against Add ping tool as a separately-releasable application module #1, now merged, which added the feature under the nametype=module).libsystemdsupports units whoseexecis a Library-type module:type=libraryloads+enables it on start and disables+unloads it on stop, instead of spawning it as a process.configs/icmp-start.dme/configs/icmp-stop.dme, the twodmellscripts that used to wrapmodule load/module enable/module unload dmicmpso atype=oneshotunit (exec=dmell args=<path to icmp-start.dme>) could drive them.configs/icmp.ininow registers dmicmp directly:exec=dmicmp+type=library- no launcher script in between.service stop icmpnow actually works: the oldtype=oneshotunit's process was already gone by the time it would run, so turning ping response back off required runningicmp-stop.dmeby hand. Withtype=library, stop disables+unloads dmicmp for real.docs/service.md, rootREADME.mdanddmicmp.dmr's resource comment to match.Test plan
type=modulenaming, anywhere in the repo (docs,.dmr, CI workflows) other than deliberate before/after mentions indocs/service.md.type=libraryis what makesicmp.iniactually work as written.🤖 Generated with Claude Code
https://claude.ai/code/session_01JibXp8rSB2Bp1DKtnQhxaQ