Skip to content

Validate Oracle dynamic column references in parser benchmarks #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cangelosilima merged 1 commit into from
Sep 26, 2026
Merged

Validate Oracle dynamic column references in parser benchmarks #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cli/benchmarks/SyncSql.Benchmarks/ParserBenchmarks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ public int AnalyzeBatch()
{
LineageAnalysisResult analysis = _analyzer.Analyze(_scripts[i]);
bool dynamic = i % 4 == 3;
// Dynamic scanners recover object references; static statements also bind columns.
// SQL Server's dynamic scanner recovers object references only. Oracle also binds columns.
if (!analysis.ObjectRefs.Any(reference => reference.Name == "V000")
|| (dynamic && !analysis.ObjectRefs.Any(reference => reference.Origin == ReferenceOrigin.Dynamic))
|| (!dynamic && !analysis.ColumnRefs.Any(reference => reference.Column == "Id")))
|| ((!dynamic || Engine == DatabaseEngine.Oracle) && !analysis.ColumnRefs.Any(reference => reference.Column == "Id")))
{
throw new InvalidOperationException("Benchmark parser lost expected table or column references.");
}
Expand Down
Loading