Skip to content

Validate Oracle dynamic column references in parser benchmarks - #65

Merged
cangelosilima merged 1 commit into
mainfrom
codex/parser-benchmark-dynamic-columns
Sep 26, 2026
Merged

cangelosilima merged 1 commit into
mainfrom
codex/parser-benchmark-dynamic-columns

Conversation

@cangelosilima

@cangelosilima cangelosilima commented Sep 26, 2026 •

Copy link
Copy Markdown
Owner

The parser benchmark previously skipped column-reference validation for all dynamic SQL, allowing Oracle dynamic column lineage to regress without failing the benchmark.

Require the expected Id column for Oracle dynamic statements while retaining the existing SQL Server dynamic object-reference checks.

Validation:

  • Both parser benchmark cases passed locally in Release.
  • GitHub CI passed: CLI builds and tests on Windows and Linux, CLI and site coverage, performance budgets, CodeQL, and the Quality gate.
  • Local site tests encountered two failures in unchanged code (localStorage availability and vendored model checksum/size). The local quality hook was bypassed after documenting those failures; the corresponding site checks passed in CI.

@github-actions

Copy link
Copy Markdown

Quality results

Quality gate: success
Commit: e2665e9ed6749032f4ade20deba49fde3d7c588f · View run and reports

Check Result
Dependency vulnerabilities success
CodeQL success
CLI lint and format success
CLI tests and coverage success
CLI performance budgets success
Site lint and format success
Site tests and coverage success
Workflow lint success
Coverage badge data success
Line coverage Measured Minimum
CLI 100% 100%
Site 100% 80%

CLI line, branch, method, and full method coverage must each reach 100%. A missing report is shown as unavailable. See the linked run for test failures, detailed CLI/Site coverage summaries and HTML reports, and scanner results.

@cangelosilima
cangelosilima marked this pull request as ready for review September 26, 2026 13:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T13:38:06.671413Z e2665e9 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cangelosilima
cangelosilima merged commit 4b2e9ed into main Sep 26, 2026
25 checks passed
@cangelosilima
cangelosilima deleted the codex/parser-benchmark-dynamic-columns branch September 26, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant