Repository navigation
Fit Vega-Lite charts to their widget and stack rows on narrow screens - #122
Merged
TanayBensuYurtturk merged 1 commit intoOct 25, 2026
Merged
Conversation
…creens Vega charts now fill the frame height and resize when the frame changes, rows drop their fixed height when stacked below 40rem, and PNG/PDF exports capture overflowing charts in full.
|
[Medium impact] The changes affect dashboard layout, chart display, and visual exports. The PR appears safe to merge, with a non-blocking request for export regression tests. Reviews (1) · Last reviewed commit: "Fit Vega-Lite charts to their widget fra..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
iremcaginyurtturk
approved these changes
Oct 25, 2026
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vega-Lite charts were sized from a fixed height and didn't follow their widget frame, so they got clipped or left gaps when descriptions wrapped or the layout changed. They now fill the frame and resize with it, rows stack without a forced height on narrow screens, and exports capture charts that overflow their widget.
Testing
make testmake buildChecklist
docs/and updated (or added) the relevant pages