Repository navigation
handoff: exports created after takeover flush - #132
Closed
jaredLunde wants to merge 2 commits into
Closed
jaredLunde wants to merge 2 commits into
jaredLunde wants to merge 2 commits into
Conversation
…e flag was never cleared) run_server_as_successor set GLIDEFS_HANDOFF_SUCCESSOR_PASSIVE for the life of the process, so every WriteCache built after takeover was born Warming and flush_packs skipped it forever: no dirty-age, threshold or any scheduler upload, and no WAL truncation. The flag is now a process-global cleared when takeover completes; no env var. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WpMBiw38GkJFe49jfZowsH
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WpMBiw38GkJFe49jfZowsH
Contributor
Author
|
Superseded by the rebased PR on branch jared/successor-flush-gate-v2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes exports created in a handoff-successor process never uploading on their own (dirty-age, threshold):
GLIDEFS_HANDOFF_SUCCESSOR_PASSIVEwas set at successor start and never cleared, so every later WriteCache was born Warming andflush_packsskipped it (checkpoint WAL truncation too).The flag is now a process-global cleared right after
set_all_caches_phase(Idle). Testtests/successor_flush.rs(own process; fails without the clear): Warming cache does not flush; existing cache flushes after takeover; post-takeover cache flushes by dirty age and by the 1,024-block threshold.🤖 Generated with Claude Code
https://claude.ai/code/session_01WpMBiw38GkJFe49jfZowsH