Repository navigation
handoff: disks created after takeover do the threshold flush - #134
Merged
Merged
Conversation
…e flag was never cleared) run_server_as_successor set GLIDEFS_HANDOFF_SUCCESSOR_PASSIVE for the life of the process, so every WriteCache built after takeover was born Warming and flush_packs skipped it forever: no dirty-age, threshold or any scheduler upload, and no WAL truncation. The flag is now a process-global cleared when takeover completes; no env var. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WpMBiw38GkJFe49jfZowsH
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WpMBiw38GkJFe49jfZowsH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #132, rebased on main after the #131 revert (no force-push). The handoff successor set GLIDEFS_HANDOFF_SUCCESSOR_PASSIVE and never cleared it, so every cache created after takeover started Warming: flush_packs skipped (no 128 MiB threshold upload) and WAL truncation was skipped, so dirty data and the WAL grew on the node until a drain or snapshot. Drain and snapshot already upload on a successor (flush_until_no_skips has no gate). Tests: tests/successor_flush.rs (pre-takeover cache does not flush; a cache that existed at takeover threshold-flushes after it; a cache created after takeover starts Idle and threshold-flushes at 1,024 blocks); fails without the clear.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WpMBiw38GkJFe49jfZowsH