Skip to content

34553 skip completing party name check for SBC staff (hotfix v3.1.19b) #4745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kialj876 merged 1 commit into from
Aug 27, 2026
Merged

34553 skip completing party name check for SBC staff (hotfix v3.1.19b) #4745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion legal-api/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "legal-api"
version = "3.1.19"
version = "3.1.19b"
description = ""
authors = [
{name = "thor",email = "1042854+thorwolpert@users.noreply.github.com"}
Expand Down
7 changes: 5 additions & 2 deletions legal-api/src/legal_api/services/filings/validations/registration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from legal_api.core.filing import Filing
from legal_api.errors import Error
from legal_api.services import STAFF_ROLE, NaicsService, flags
from legal_api.services.authz import SBC_STAFF_ROLE
from legal_api.services.filings.validations.common_validations import (
is_same_str,
validate_court_order,
Expand Down Expand Up @@ -171,14 +172,16 @@ def validate_completing_party_name(filing: dict, filing_type="registration") ->
"""Validate the completing party name matches the submitting user's name.

Clients cannot edit the completing party (it is pre-populated from their login),
so the submitted name must match their user record; staff enter it manually from
a paper form and API gateway users have their own workflow, so both are skipped.
so the submitted name must match their user record; registry and SBC staff enter it
manually from a paper form and API gateway users have their own workflow, so those
are skipped.
"""
api_login_source = "API_GW" # jwt loginSource of an API gateway user
msg = []
current_user = getattr(request_ctx, "current_user", None) if has_request_context() else None
if (not current_user
or jwt.validate_roles(current_user, [STAFF_ROLE])
or jwt.validate_roles(current_user, [SBC_STAFF_ROLE])
or current_user.get("loginSource") == api_login_source):
return msg

Expand Down
3 changes: 2 additions & 1 deletion legal-api/tests/unit/services/filings/validations/test_registration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
from business_model.models import Business, User
from legal_api.services import NaicsService, NameXService, flags
from legal_api.services.filings.validations.validation import validate
from legal_api.services.authz import BASIC_USER, STAFF_ROLE
from legal_api.services.authz import BASIC_USER, SBC_STAFF_ROLE, STAFF_ROLE
from registry_schemas.example_data import FILING_HEADER, REGISTRATION

from tests.unit.services.filings.validations import create_party, create_party_address
Expand Down Expand Up @@ -457,6 +457,7 @@ def mock_check(permissions_msg, filing_type):
MISMATCH_ERROR),
('client_user_record_no_name', [BASIC_USER], 'BCSC', (None, None, None), None, MISMATCH_ERROR),
('staff_skipped', [STAFF_ROLE], 'IDIR', ('Different', None, 'Person'), None, None),
('sbc_staff_skipped', [SBC_STAFF_ROLE], 'IDIR', ('Different', None, 'Person'), None, None),
('api_gw_skipped', [BASIC_USER], 'API_GW', ('Different', None, 'Person'), None, None),
]
)
Expand Down