34553 skip completing party name check for SBC staff (hotfix v3.1.19b) - #4745
Merged
kialj876 merged 1 commit intoAug 27, 2026
Conversation
kialj876
approved these changes
Aug 27, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: bcgov/entity#34553
Description of changes:
Exclude the sbc_staff role (alongside staff) from the logged-in user name check on firm registrations, since SBC staff enter the completing party manually from the paper form. Re-cut of #4741 on hotfix-v3.1.19b, branched from the commit actually deployed to prod (3bc88f4) so the image carries the business-model migration already applied there.