Repository navigation
Patch rustls and move to Go 1.26.9 for new security advisories - #989
Conversation
rustls 0.23.45 -> 0.23.46 in rust/Cargo.lock clears RUSTSEC-2026-0346, -0347, -0348 and -0349, all patched in >=0.23.46. The conformance runner workspace doesn't depend on rustls. The go/go.mod toolchain moves from go1.26.8 to go1.26.9, which carries the net/http fixes for GO-2026-6617 and GO-2026-6613. Every setup-go step reads its version from go/go.mod, so CI follows.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approved
The changes are narrowly scoped security patch updates, with reported successful validation and no unresolved findings.
0 open findings
What changed in this PR
Updates Rust and Go security patch versions to address advisories blocking the SDK’s security checks.
Changes:
- Updates
rustlsfrom 0.23.45 to 0.23.46 and refreshes its checksum. - Updates the Go toolchain from 1.26.8 to 1.26.9.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
rust/Cargo.lock |
Locks the patched rustls version and checksum. |
go/go.mod |
Selects the patched Go toolchain. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Main's Security run has been red since 2026-10-12, and every PR's checks with it:
cargo denyfails on new rustls advisories and govulncheck on new Go stdlib net/http advisories. Two lines fix both.Debugimpls for client session values expose TLS secretsrust/Cargo.lockrustls 0.23.45>=0.23.46)go/go.modtoolchain go1.26.8toolchain go1.26.9cargo update -p rustlsinrust/; only rustls moved (hyper-rustls, tokio-rustls, rustls-platform-verifier, rustls-webpki already accept 0.23.46). Theconformance/runner/rustworkspace doesn't depend on rustls and already passescargo deny.go/go.mod'stoolchainline was the only 1.26.8 pin. Everysetup-gostep readsgo-version-file: go/go.mod;.mise.tomlfloats on1.26, and the othergo.modfiles andgo.workcarry no toolchain line. No Dockerfiles pin Go.Verified locally (each gated on exit status):
make rs-check(incl.cargo denyover both workspaces),govulncheck ./...under go1.26.9 ("No vulnerabilities found"),make go-check,conformance-runner-tests-{go,rust},conformance-{go,rust}(312/312 Rust; 310 pass, 2 skipped Go).Summary by cubic
Fixes the security checks that have been red since 2026-10-12 by updating
rustlsto 0.23.46 and the Go toolchain to 1.26.9. These clear four newrustlsadvisories (RUSTSEC-2026-0346 through -0349) and two Gonet/httpadvisories (GO-2026-6617 and GO-2026-6613) that were failingcargo denyandgovulncheckon every PR.Bug Fixes
cargo update -p rustlsinrust/; onlyrustlsmoved, and the conformance runner workspace doesn't depend on it.go/go.mod'stoolchainline was the only 1.26.8 pin; everysetup-gostep reads its version from that file.Written for commit 7d2ad80. Summary will update on new commits.