Skip to content

[BUGFIX] prevent cache flushing when no files found #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
achimfritz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[BUGFIX] prevent cache flushing when no files found #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Classes/Command/CompressImagesCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,10 @@ protected function execute(InputInterface $input, OutputInterface $output): void
foreach ($this->fileStorageRepository->findAll() as $fileStorage) {
$excludeFolders = GeneralUtility::trimExplode(',', (string)$settings['excludeFolders'], true);
$files = $this->fileRepository->findAllNonCompressedInStorageWithLimit($fileStorage, $limit, $excludeFolders);
$this->compressImages($files);
$this->clearPageCache();
if (count($files) > 0) {
Copy link
Copy Markdown
Member

@bmack bmack Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only use count() if there is always an array, othwise we'll get a PHP warning from PHP 7.2+. Safer it's to use if (!empty($files)) plus it's also faster than count.

$this->compressImages($files);
$this->clearPageCache();
}
}
}

Expand Down