[BUGFIX] prevent cache flushing when no files found#10
Open
achimfritz wants to merge 1 commit intomasterfrom
Open
[BUGFIX] prevent cache flushing when no files found#10achimfritz wants to merge 1 commit intomasterfrom
achimfritz wants to merge 1 commit intomasterfrom
Conversation
bmack
requested changes
Dec 9, 2019
| $files = $this->fileRepository->findAllNonCompressedInStorageWithLimit($fileStorage, $limit, $excludeFolders); | ||
| $this->compressImages($files); | ||
| $this->clearPageCache(); | ||
| if (count($files) > 0) { |
Member
There was a problem hiding this comment.
only use count() if there is always an array, othwise we'll get a PHP warning from PHP 7.2+. Safer it's to use if (!empty($files)) plus it's also faster than count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.