Skip to content

scripts/dtc: apple-dart-pd-check: skip disabled DARTs no enabled device uses - #2605

Merged
RyanTheTide merged 1 commit into
integration/aurorafrom
dtcheck/dart-pd-skip-disabled
Nov 20, 2026
Merged

RyanTheTide merged 1 commit into
integration/aurorafrom
dtcheck/dart-pd-skip-disabled

Conversation

@RyanTheTide

Copy link
Copy Markdown
Contributor

Problem. apple-dart-pd-check.py reports any DART that names a disabled power state, including a DART that is itself status = "disabled". When the DART, its device and their power state are all disabled, the block is just off, and that is consistent. A new board DTB that keeps unsupported blocks disabled fails on every one of them. On #2102 (J775c), 22 of the 55 new findings are of this kind.

Change. A disabled DART is skipped when no enabled device uses it through iommus or iommu-map. A device counts as enabled only when it and every node above it are okay, so a piodma under a disabled DCP does not count. The checker still reports:

  • an enabled DART that names a disabled power state or none
  • a disabled DART that an enabled device uses. The boot loader enables such DARTs when it hands their device over, which is the T6040 display case behind f156db2.

Testing.

Still to run. CI on this PR.

The 3 disabled-DART findings that stay on #2102
t6050-j775c /soc/iommu@2309020000 avd_dart apple,t6050-dart disabled: power domain /soc/power-management@2380600000/power-controller@1d8 is disabled (new)
t6050-j775c /soc/iommu@410000000 dart_apcie0 apple,t6050-dart disabled: no power-domains (new)
t6050-j775c /soc/iommu@411000000 dart_apcie1 apple,t6050-dart disabled: no power-domains (new)
  • avd@2309080000 is enabled (no status). Its own power-domains = <&ps_avd_sys> is disabled, and its DART is disabled too, so the decoder cannot probe as the DTB stands.
  • pcie0 is enabled in arm64: dts: apple: support M5 Max Mac Studio (J775c) #2102 (it is disabled in the base). Its iommu-map sends RIDs 0x300 and 0x400 to dart_apcie0/dart_apcie1. Both DARTs are disabled and name no power domain.
Counts and totals
rc total new fixed
old checker, base vs #2102 1 899 55 (33 okay + 22 disabled DARTs) 43
new checker, base vs #2102 1 123 36 (33 okay + 3 disabled DARTs with an enabled user) 11
new checker, base vs base 0 98 0 0

The total drops because disabled DARTs that nothing enabled uses are no longer counted. They made up most of the old 899.

Assisted-by: LLM (Claude:Opus 5.5)

…ce uses

The checker reported a DART that names a disabled power state whatever
the DART's own status, because the boot loader enables DARTs the device
tree leaves disabled when it hands their device over (the T6040 internal
display). It also reported a disabled DART for that whole block being
off: the DART, its device and their power state all disabled, which is
consistent. A new board DTB that keeps the blocks it does not support
yet disabled then fails on every one of them; the J775c DTB had 22 such
findings.

Skip a disabled DART when no enabled device uses it through iommus or
iommu-map. A device counts as enabled when it and every node above it
are okay, so a DCP's piodma under a disabled DCP does not count. An
enabled DART that names a disabled or no power state is still reported,
and so is a disabled DART that an enabled device uses: the loader may
enable it.

Self-tests cover a disabled DART on a disabled domain (skipped), one
used only under a disabled node (skipped), an enabled DART on a
disabled or missing domain (fails) and a disabled DART used by an
enabled device (fails).

Fixes: f156db2 ("scripts/dtc: flag any DART that names a disabled power state")
Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
@RyanTheTide
RyanTheTide merged commit 4e58401 into integration/aurora Nov 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant