Repository navigation
scripts/dtc: apple-dart-pd-check: skip disabled DARTs no enabled device uses - #2605
Merged
Merged
Conversation
…ce uses The checker reported a DART that names a disabled power state whatever the DART's own status, because the boot loader enables DARTs the device tree leaves disabled when it hands their device over (the T6040 internal display). It also reported a disabled DART for that whole block being off: the DART, its device and their power state all disabled, which is consistent. A new board DTB that keeps the blocks it does not support yet disabled then fails on every one of them; the J775c DTB had 22 such findings. Skip a disabled DART when no enabled device uses it through iommus or iommu-map. A device counts as enabled when it and every node above it are okay, so a DCP's piodma under a disabled DCP does not count. An enabled DART that names a disabled or no power state is still reported, and so is a disabled DART that an enabled device uses: the loader may enable it. Self-tests cover a disabled DART on a disabled domain (skipped), one used only under a disabled node (skipped), an enabled DART on a disabled or missing domain (fails) and a disabled DART used by an enabled device (fails). Fixes: f156db2 ("scripts/dtc: flag any DART that names a disabled power state") Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem.
apple-dart-pd-check.pyreports any DART that names a disabled power state, including a DART that is itselfstatus = "disabled". When the DART, its device and their power state are all disabled, the block is just off, and that is consistent. A new board DTB that keeps unsupported blocks disabled fails on every one of them. On #2102 (J775c), 22 of the 55 new findings are of this kind.Change. A disabled DART is skipped when no enabled device uses it through
iommusoriommu-map. A device counts as enabled only when it and every node above it are okay, so apiodmaunder a disabled DCP does not count. The checker still reports:Testing.
scripts/dtc/apple-dart-pd-check-test.py: 11/11 OK. Four new cases: a disabled DART on a disabled domain (skipped), a disabled DART used only under a disabled node (skipped), an enabled DART on a disabled or missing domain (fails) and a disabled DART used by an enabled device (fails). The old checker fails the two skip cases.LLVM=1,DTC_FLAGS=-@): baseintegration/aurora789b208 vs. its merge with arm64: dts: apple: support M5 Max Mac Studio (J775c) #2102 head 3c72bab.Still to run. CI on this PR.
The 3 disabled-DART findings that stay on #2102
avd@2309080000is enabled (no status). Its ownpower-domains = <&ps_avd_sys>is disabled, and its DART is disabled too, so the decoder cannot probe as the DTB stands.pcie0is enabled in arm64: dts: apple: support M5 Max Mac Studio (J775c) #2102 (it is disabled in the base). Itsiommu-mapsends RIDs 0x300 and 0x400 todart_apcie0/dart_apcie1. Both DARTs are disabled and name no power domain.Counts and totals
The total drops because disabled DARTs that nothing enabled uses are no longer counted. They made up most of the old 899.
Assisted-by: LLM (Claude:Opus 5.5)