Skip to content

scripts/dtc: apple-dart-pd-check: a DART inside a disabled node is disabled - #2608

Merged
DjDeveloperr merged 1 commit into
integration/aurorafrom
satchlj/dart-pd-check-ancestors-20261120
Nov 20, 2026
Merged

DjDeveloperr merged 1 commit into
integration/aurorafrom
satchlj/dart-pd-check-ancestors-20261120

Conversation

@satchlj

@satchlj satchlj commented Nov 20, 2026

Copy link
Copy Markdown
Member

Claude Opus 5.5 on @satchlj's behalf.

apple-dart-pd-check.py skips a disabled DART that no enabled device uses, but it reads only the DART's own status. A router's DART (acio@…/iommu@a80000) usually has no status of its own and sits inside the router. With the router disabled, the checker read the DART as okay and reported it against the router's disabled domain, although Linux never populates the children of a disabled node.

This makes the skip use the existing ancestor-aware enabled() for the DART as well (one line).

Effect on #2102's T6050 DTBs: all 11 boards built at #2102's head 3c72babd, with the merge base 677be395 as the baseline.

Tests: two new ones, 13 in all, which pass.

  • A DART inside a disabled node is skipped. This test fails on the tip's checker.
  • A DART inside an enabled node on a disabled domain still fails.

🤖 Generated with Claude Code

…sabled

The skip for disabled DARTs that no enabled device uses read only the
DART's own status. A router's DART (acio@.../iommu@a80000) usually has
no status of its own and sits inside the router, so with the router
disabled it was read as okay and reported against the router's disabled
domain, although Linux never populates children of a disabled node.

Use the existing ancestor-aware enabled() for the DART too. On the T6050
DTBs of linux#2102 this removes 32 findings, all ACIO DARTs inside
disabled acio routers on J714c/s, J716c/s, J775d, J873s and K114/K116;
the routers those boards enable keep their findings checked. Two tests:
a DART inside a disabled node is skipped, one inside an enabled node on
a disabled domain still fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Satya Benson <satya@benson.earth>

@DjDeveloperr DjDeveloperr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right. enabled() already walks every ancestor, so treating a DART as off when any node above it is disabled is the same rule the consumers check uses. The two tests cover both directions: a DART inside a disabled router is skipped, and one inside an enabled router on a disabled domain still fails. Approving; it merges once dt-checks and host-tests are green on this head.

@DjDeveloperr
DjDeveloperr merged commit 2e1b085 into integration/aurora Nov 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants