Repository navigation
scripts/dtc: apple-dart-pd-check: a DART inside a disabled node is disabled - #2608
Merged
DjDeveloperr merged 1 commit intoNov 20, 2026
Merged
Conversation
…sabled The skip for disabled DARTs that no enabled device uses read only the DART's own status. A router's DART (acio@.../iommu@a80000) usually has no status of its own and sits inside the router, so with the router disabled it was read as okay and reported against the router's disabled domain, although Linux never populates children of a disabled node. Use the existing ancestor-aware enabled() for the DART too. On the T6050 DTBs of linux#2102 this removes 32 findings, all ACIO DARTs inside disabled acio routers on J714c/s, J716c/s, J775d, J873s and K114/K116; the routers those boards enable keep their findings checked. Two tests: a DART inside a disabled node is skipped, one inside an enabled node on a disabled domain still fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Satya Benson <satya@benson.earth>
DjDeveloperr
approved these changes
Nov 20, 2026
DjDeveloperr
left a comment
Contributor
There was a problem hiding this comment.
Looks right. enabled() already walks every ancestor, so treating a DART as off when any node above it is disabled is the same rule the consumers check uses. The two tests cover both directions: a DART inside a disabled router is skipped, and one inside an enabled router on a disabled domain still fails. Approving; it merges once dt-checks and host-tests are green on this head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Opus 5.5 on @satchlj's behalf.
apple-dart-pd-check.pyskips a disabled DART that no enabled device uses, but it reads only the DART's ownstatus. A router's DART (acio@…/iommu@a80000) usually has nostatusof its own and sits inside the router. With the router disabled, the checker read the DART asokayand reported it against the router's disabled domain, although Linux never populates the children of a disabled node.This makes the skip use the existing ancestor-aware
enabled()for the DART as well (one line).Effect on #2102's T6050 DTBs: all 11 boards built at #2102's head
3c72babd, with the merge base677be395as the baseline.okay.disabledon J714c/s, J716c/s, J775d, J873s and K114/K116.dart_apcie0..3with nopower-domains, andavd_dart. Those are for arm64: dts: apple: support M5 Max Mac Studio (J775c) #2102 to fix.Tests: two new ones, 13 in all, which pass.
🤖 Generated with Claude Code