Repository navigation
arm64: dts: apple: t6050-k114c: boot NOR and read-only nvram partition - #2563
Conversation
…partition Enable the QSPI controller with a jedec,spi-nor flash on chip select 0 and the 0xc0000-byte nvram partition at 0x700000, read-only, so asahi-bless can read the boot state. The flash ID is probed by spi-nor. Signed-off-by: Joshua Warren <816217+joshuaswarren@users.noreply.github.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Thanks for re-sending this with the sign-off. The diff is identical to #1738 at 6b26ff4, so our earlier review carries over: the description is fine and the nvram partition is read-only. What is still missing is the hardware row on K114c that you list yourself: spi-nor identifies the boot NOR, Could you also close #1738 now that this one replaces it, so only one copy stays open? |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Thanks. 18cfec4 has the same parent (0abc2f3) and the same tree (14444d73) as #1738's 6b26ff4, the head I reviewed, and it adds the Signed-off-by that held #1738. dt-checks and host-tests are green on this head, and integration/aurora hasn't touched t6050-k114c.dts since that parent. Merging.
After the merge, from a K114c boot that carries the read-only partition, with a revert ready:
- the spi-nor identify line;
/proc/mtdshowingnvram;- the boot-state tool reading the boot target and volumes back.
09425ce
into
aurora-silicon:integration/aurora
|
Merged as 09425ce. The post-merge rows are in my review above, and a revert is ready if one of them fails. |
|
J775c (lobata) row request — NOR and SD (sheet row M, rebuilt on #2563) Posted by Joshua's lane (wB4) from the 2026-11-20 K114c row set. We supply no image for this; it needs a tree with the J775c DTB (the built M image is stale; rebuild on #2563, now merged as Heads: Commands: save Pass: card read/write works, all three wakes return the host and the mmc host, NOR shows |
Replaces #1738 to add the missing author DCO sign-off without a force push. The parent and tree are unchanged from 6b26ff4 (tree 14444d7330eba9121f4a4565b2eeff4ecb823ab4).
Enables K114c QSPI boot NOR with a read-only nvram partition and alias for the boot-state tool. No writes are added. The original tree built the K114c DTB with the same warnings as base; CI on this signed commit is separate. Post-merge hardware evidence remains open: spi-nor identify, /proc/mtd nvram, and readback of boot target and volumes. No boot attempted for this replacement.