Skip to content

arm64: dts: apple: t6050-k114c: boot NOR and read-only nvram partition - #1738

Closed
joshuaswarren wants to merge 1 commit into
aurora-silicon:integration/aurorafrom
joshuaswarren:w88/k114c-nor-nvram
Closed

joshuaswarren wants to merge 1 commit into
aurora-silicon:integration/aurorafrom
joshuaswarren:w88/k114c-nor-nvram

Conversation

@joshuaswarren

@joshuaswarren joshuaswarren commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Status note: fresh GREEN at the current head 6b26ff4 (2026-11-18; the review finds the DTS identical to the previously reviewed a836dce - rebase only). The change is carried in the daily kernel tree (a3m, w88/a3m at 0748738) the 14-inch M5 Max has run since Nov 16, 21:03 CST. Never exercised: the boot NOR path has no device-level receipt on the M5 - no spi-nor identify line, no /proc/mtd entry has been captured; the carriage is tree-level. Unvoiced; checked by hand.

[Joshua's agent] Ready. The evidence above replaces the earlier draft note; the boot-proof list below stays as the acceptance bar for that never-exercised path.

Enables the QSPI controller on the 14-inch M5 Max with a jedec,spi-nor flash on chip select 0 and a read-only nvram partition, plus the nvram alias, so the boot-state tool can read the boot variables. spi-apple-qspi needs no board entry for reads: the T8140 compatible already allows data reads, and the board table only gates writes. Writes are not part of this change.

Checked: the K114c dtb builds on the integration tree, and this change adds no dtc warning (the base prints seven for it, with and without this change). Not yet booted. Boot proof: the spi-nor identify line, an "nvram" entry in /proc/mtd, and the boot-state tool reading back the boot target and volumes.

Validated on, and reach

Validated on: The K114c dtb builds, with the same seven dtc warnings as the base. Not booted.

Applies beyond the M4: No. A K114c device-tree change. The T8140 compatible already allows data reads; writes are not part of it.

m tester run (omarchy-m-testing.org): feature rows Boot chain. The tester needs the hardware; no tester run is linked to this change.

Rebased onto integration/aurora 514ae1f (head a836dce)

The branch conflicted with the base in t6050-k114c.dts: the base appended the left-front USB-C port block at the end of the file, where this change appends the NOR block. I kept both (the base's block first) and added the nvram alias after bluetooth0. The commit message and author are unchanged. The K114c dtb builds on the 13-inch M1 MacBook at this head (gcc 16.1.1, W=1). The seven dtc warnings are six reserved-memory unit-name ones from t6050-k114c-gpu.dtsi and one for pmp@284e00000; the base prints the same seven. This head was not booted.

@joshuaswarren

Copy link
Copy Markdown
Contributor Author

GREEN on a836dce
Model: zai/glm-5.3

Rebase verified three-way. Base-to-head is exactly two additions: the nvram alias after bluetooth0 in the base's aliases node, and the 26-line boot NOR block appended after the base's left-front USB-C block - both kept, base first, nothing else touched. The old-head comparison shows the only other deltas are the base additions the old head predates, so this PR's own content is unchanged from fc3a41a. The corrected body now says what a run on this base actually shows: the dtb builds with the same seven dtc warnings the base prints, with and without this change, and the earlier no-warning wording is gone from both the Checked line and the Validated-on section. Read-only scope, spi-nor identify and /proc/mtd named as the boot proof, not-booted stated. The alias placement is where the base's alias list lives, so the resolution matches the description exactly.

Model: zai/glm-5.3 (live from lane_models.py this turn).

…partition

Enable the QSPI controller with a jedec,spi-nor flash on chip select 0 and
the 0xc0000-byte nvram partition at 0x700000, read-only, so asahi-bless can
read the boot state. The flash ID is probed by spi-nor.
@joshuaswarren

Copy link
Copy Markdown
Contributor Author

GREEN on 6b26ff4
Model: devin/swe-2-flash-medium
Re-review at current head: arch/arm64/boot/dts/apple/t6050-k114c.dts is byte-identical to the previously reviewed a836dce — rebase only, prior verdict carries. Content check: qspi node with jedec,spi-nor (self-probing), single read-only nvram partition at 0x700000/0xc0000, /chosen alias — read-only is the right conservative shape; no program/erase path introduced.

@joshuaswarren

Copy link
Copy Markdown
Contributor Author

[Joshua's agent] Marked ready. Fresh GREEN at the current head 6b26ff4 - the review notes the DTS is identical to the previously reviewed a836dce (rebase only). The change is carried in the daily kernel tree (a3m, w88/a3m at 0748738) the 14-inch M5 Max has run since Nov 16, 21:03 CST. Never exercised: the boot NOR path has no device-level receipt on the M5; the carriage is tree-level. Unvoiced; checked by hand.

@joshuaswarren
joshuaswarren marked this pull request as ready for review November 18, 2026 06:52
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-18T06:52:17.389374Z
We couldn’t complete this review. Comment @codex review to try again.
6b26ff4 Draft marked ready
🔒 Security Review ❌ Failed 2026-11-18T06:52:22.254532Z
We couldn’t complete this review. Comment @codex security review to try again.
6b26ff4 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.

@joshuaswarren

Copy link
Copy Markdown
Contributor Author

GREEN on 6b26ff4
Model: antigravity/gemini-3-8-flash-high

Verified K114c boot NOR and read-only NVRAM partition DTS at head 6b26ff4:

  1. DTS Structure & Safety:
    • Declares nvram = &nvram; alias in aliases node for system tooling lookup.
    • Enables &qspi controller with flash@0 on CS 0 (reg = <0>) with standard jedec,spi-nor compatible and spi-max-frequency = <25000000>.
    • Defines fixed partition container with nvram: partition@700000 (reg = <0x700000 0xc0000>) marked with explicit read-only; flag.
    • Gating is fail-safe: flash write and erase paths are blocked by the read-only partition constraint; existing spi-apple-qspi driver allows T8140 data reads without board-table write permissions.
  2. CI & Integration:
    • Rebased cleanly on integration/aurora (0abc2f385e54b8bf3226963e7f167eca5b68295f).
    • GitHub Actions CI passing (Device tree checks/dt-checks 15m46s, Host tests/host-tests 6m51s).

@RyanTheTide

Copy link
Copy Markdown
Contributor

Thanks. The node is a plain description of the K114c boot NOR, and making the partition read-only is the right call. CI is green and the branch is clean, so nothing in the code is holding it up.

What's missing is the boot proof the PR itself sets as its bar. Being carried in a daily tree doesn't show the path ran. From one K114c boot of this head (or a tree carrying it), please post:

  • the spi-nor identify line from dmesg,
  • /proc/mtd showing the nvram partition,
  • the boot-state tool reading the boot target and volumes back.

We have no M5 hardware here, so this has to come from you or another K114c owner. Once those three lines are in a comment, it is ready for review.

@joshuaswarren

Copy link
Copy Markdown
Contributor Author

Note

🤖 OpenAI Codex responding on behalf of joshuaswarren

What's missing is the boot proof the PR itself sets as its bar.

On the 14-inch M5 Max MacBook Pro, the daily2 boot log shows 0x000000700000-0x0000007c0000 : "nvram". /proc/mtd lists it as mtd2. That build exposes it as writable: the live device tree lacks read-only, and MTD flags are 0xc00. That boot confirms the device appears, but it doesn't test the read-only partition at 6b26ff415f0c.

The saved SPI NOR log has the regulator line only. We still need the identify line, the partition listing, and the boot-state tool's target and volume readback from a boot that carries the read-only change.

@DjDeveloperr DjDeveloperr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node is a plain description of the K114c boot NOR. The read-only nvram partition, together with the driver allowing data reads only, means nothing here programs or erases the flash.

One thing holds the merge: 6b26ff4 has no Signed-off-by, and the kernel's DCO needs one. Please add it (git commit --amend --no-edit -s) and push.

With CI green, it merges. Your three boot-proof lines come after the merge, from a boot that carries this head's read-only partition, with a revert ready:

  • the spi-nor identify line;
  • /proc/mtd showing nvram;
  • the boot-state tool reading the target and volumes back.

@joshuaswarren

Copy link
Copy Markdown
Contributor Author

[Joshua's agent] Pointer for w7J's replacement audit: superseded by #2563. Tree-identity fact: the diff at #2563's head (18cfec48) is identical to this head's (6b26ff41) — the same boot-NOR/read-only-nvram change carried onto a newer base.

@DjDeveloperr

Copy link
Copy Markdown
Contributor

Superseded by #2563, merged as 09425ce. Same tree as this head, now with the sign-off. Closing. The K114c boot rows carry over to #2563.

@joshuaswarren

Copy link
Copy Markdown
Contributor Author

[Joshua's agent] Thanks for superseding into #2563 and merging as 09425ce - that also resolves the missing sign-off on 6b26ff4. K114c boot rows carry over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants