Repository navigation
arm64: dts: apple: t6050-k114c: boot NOR and read-only nvram partition - #1738
joshuaswarren wants to merge 1 commit into
Conversation
fc3a41a to
a836dce
Compare
|
GREEN on a836dce Rebase verified three-way. Base-to-head is exactly two additions: the nvram alias after bluetooth0 in the base's aliases node, and the 26-line boot NOR block appended after the base's left-front USB-C block - both kept, base first, nothing else touched. The old-head comparison shows the only other deltas are the base additions the old head predates, so this PR's own content is unchanged from fc3a41a. The corrected body now says what a run on this base actually shows: the dtb builds with the same seven dtc warnings the base prints, with and without this change, and the earlier no-warning wording is gone from both the Checked line and the Validated-on section. Read-only scope, spi-nor identify and /proc/mtd named as the boot proof, not-booted stated. The alias placement is where the base's alias list lives, so the resolution matches the description exactly. Model: zai/glm-5.3 (live from lane_models.py this turn). |
…partition Enable the QSPI controller with a jedec,spi-nor flash on chip select 0 and the 0xc0000-byte nvram partition at 0x700000, read-only, so asahi-bless can read the boot state. The flash ID is probed by spi-nor.
a836dce to
6b26ff4
Compare
|
GREEN on 6b26ff4 |
|
[Joshua's agent] Marked ready. Fresh GREEN at the current head 6b26ff4 - the review notes the DTS is identical to the previously reviewed a836dce (rebase only). The change is carried in the daily kernel tree (a3m, w88/a3m at 0748738) the 14-inch M5 Max has run since Nov 16, 21:03 CST. Never exercised: the boot NOR path has no device-level receipt on the M5; the carriage is tree-level. Unvoiced; checked by hand. |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
|
GREEN on 6b26ff4 Verified K114c boot NOR and read-only NVRAM partition DTS at head 6b26ff4:
|
|
Thanks. The node is a plain description of the K114c boot NOR, and making the partition What's missing is the boot proof the PR itself sets as its bar. Being carried in a daily tree doesn't show the path ran. From one K114c boot of this head (or a tree carrying it), please post:
We have no M5 hardware here, so this has to come from you or another K114c owner. Once those three lines are in a comment, it is ready for review. |
|
Note 🤖 OpenAI Codex responding on behalf of joshuaswarren
On the 14-inch M5 Max MacBook Pro, the daily2 boot log shows The saved SPI NOR log has the regulator line only. We still need the identify line, the partition listing, and the boot-state tool's target and volume readback from a boot that carries the read-only change. |
DjDeveloperr
left a comment
There was a problem hiding this comment.
The node is a plain description of the K114c boot NOR. The read-only nvram partition, together with the driver allowing data reads only, means nothing here programs or erases the flash.
One thing holds the merge: 6b26ff4 has no Signed-off-by, and the kernel's DCO needs one. Please add it (git commit --amend --no-edit -s) and push.
With CI green, it merges. Your three boot-proof lines come after the merge, from a boot that carries this head's read-only partition, with a revert ready:
- the spi-nor identify line;
/proc/mtdshowingnvram;- the boot-state tool reading the target and volumes back.
[Joshua's agent] Ready. The evidence above replaces the earlier draft note; the boot-proof list below stays as the acceptance bar for that never-exercised path.
Enables the QSPI controller on the 14-inch M5 Max with a jedec,spi-nor flash on chip select 0 and a read-only nvram partition, plus the nvram alias, so the boot-state tool can read the boot variables. spi-apple-qspi needs no board entry for reads: the T8140 compatible already allows data reads, and the board table only gates writes. Writes are not part of this change.
Checked: the K114c dtb builds on the integration tree, and this change adds no dtc warning (the base prints seven for it, with and without this change). Not yet booted. Boot proof: the spi-nor identify line, an "nvram" entry in /proc/mtd, and the boot-state tool reading back the boot target and volumes.
Validated on, and reach
Validated on: The K114c dtb builds, with the same seven dtc warnings as the base. Not booted.
Applies beyond the M4: No. A K114c device-tree change. The T8140 compatible already allows data reads; writes are not part of it.
m tester run (omarchy-m-testing.org): feature rows Boot chain. The tester needs the hardware; no tester run is linked to this change.
Rebased onto integration/aurora 514ae1f (head a836dce)
The branch conflicted with the base in
t6050-k114c.dts: the base appended the left-front USB-C port block at the end of the file, where this change appends the NOR block. I kept both (the base's block first) and added thenvramalias afterbluetooth0. The commit message and author are unchanged. The K114c dtb builds on the 13-inch M1 MacBook at this head (gcc 16.1.1,W=1). The seven dtc warnings are six reserved-memory unit-name ones fromt6050-k114c-gpu.dtsiand one forpmp@284e00000; the base prints the same seven. This head was not booted.