Repository navigation
scripts/dtc: apple-dart-pd-check: let a new DTB inherit its SoC's known gaps - #2560
Merged
Merged
Conversation
…wn gaps The DART power-domain check compares findings per DTB name, so a DTB the base revision does not have reports every existing gap as new. A firmware-profile variant such as t8112-j413-fw27 includes t8112-j413.dts and so repeats J413's known iommu@24e808000 gap under a new name, which fails the check although nothing changed in the DART nodes. For a DTB the baseline lacks, look its findings up in the baseline DTBs of the same SoC (root "apple,tNNNN" compatible), matching node path, DART compatible and problem. A match is reported as inherited and does not fail; anything else the new DTB adds is still new. DTBs that exist in the baseline keep the strict per-board comparison. Add a self-test with synthetic fixtures (the J413 fw27 case, a variant with a gap of its own, a new DTB of another SoC, a new gap on an existing board, a changed problem on the same node) and run it in the dt-checks job. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. The dt-checks step "DART power domains, base vs head" compares findings per DTB name. A DTB that the base revision does not have reports every gap it contains as new, even the ones it inherits. On #2525 the new firmware-profile variant
t8112-j413-fw27includest8112-j413.dts, so J413's existing/soc/iommu@24e808000gap (one of the known ones) shows up as(new)and fails the job.Change. For a DTB the baseline lacks, its findings are looked up in the baseline DTBs of the same SoC (the root
apple,tNNNNcompatible), matching node path, DART compatible and problem. A match is reported as(inherited from <board>)and does not fail; anything else the new DTB adds is still new. DTBs that already exist in the baseline keep the strict per-board comparison. The summary line gains aninherited by new DTBscount. A self-test (scripts/dtc/apple-dart-pd-check-test.py, dtc + pylibfdt fixtures) now runs in the job.Testing.
t8112-j413-fw27 /soc/iommu@24e808000 - apple,t8112-dart okay: no power-domains (new),new: 1DARTs without a usable power domain: 887, new: 0, inherited by new DTBs: 1, fixed: 0Still to run. This PR's own dt-checks job; then a re-run of #2525's dt-checks once this is merged.
Self-test cases
--baseline-dtb-direvery gap failsAssisted-by: LLM (Claude:Opus 5.5)