Skip to content

arm64: dts: apple: t8132-j713-j715: DisplayPort alt mode on both USB-C ports - #2246

Closed
RyanTheTide wants to merge 1 commit into
integration/aurorafrom
spec-m3m4/j713-j715-dp-alt-mode
Closed

RyanTheTide wants to merge 1 commit into
integration/aurorafrom
spec-m3m4/j713-j715-dp-alt-mode

Conversation

@RyanTheTide

@RyanTheTide RyanTheTide commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Problem. The MacBook Air M4 (J713/J715) has two USB-C ports on ATC0/ATC1, each with its display crossbar, wired like the J604's left ports. DP alt mode already runs there through the T8132 PHY support (apple,dp-alt-mode in drivers/phy/apple/atc.c). The Air DT still has a note from before that support, saying these PHYs have no DP alt mode. So a plain USB-C monitor or a USB-C to HDMI/DP adapter (anything not USB4/Thunderbolt) gets no picture.

Change. Mark atcphy0 and atcphy1 with apple,dp-alt-mode and fix the comments. The dcpext routes, their loader gate and the tunnel path are unchanged. apple,dp-alt-mode is the board-wiring property the PHY driver already reads (J604 sets it on its three USB-C ports and not on ATC2, which drives HDMI).

Testing. cpp + dtc on all six T8132 boards: same warning counts as the base.

Still to run. On a J713 or J715: a non-Thunderbolt USB-C monitor on each port (mode set, hotplug, one s2r), and a USB4 display to confirm the tunnel path is unchanged.

Assisted-by: LLM (Claude:Opus 5.5)

…C ports

The MacBook Air M4's two USB-C ports are ATC0 and ATC1 with their display
crossbars, the same PHYs and routes as the J604's left ports, where DP alt
mode runs since the T8132 PHY gained it (apple,dp-alt-mode). The Air DT
still said the PHYs had no DP alt mode, a note from before that support,
so a USB-C monitor or a USB-C to HDMI adapter got no picture unless it
was a USB4/Thunderbolt display.

Mark both PHYs. The dcpext routes, their boot-loader gate and the tunnel
path are unchanged.

Not tested on hardware; needs a J713/J715
run with a USB-C (non-TB) monitor on each port.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@RyanTheTide

Copy link
Copy Markdown
Contributor Author

Blockers: 2.

  1. Commit 0eaae34 has no Signed-off-by and ends with Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>. Add the human sign-off and drop the trailer.

  2. This turns on a new PHY path on a Mac that is on hand, so it needs the J713 run before merge. On the Air, a non-USB4 USB-C sink now takes the T8132 DP alt mode sequences in the PHY (atcphy_t8132_dp_on(), drivers/phy/apple/atc.c:3618, now true on ATC0/ATC1). The J604 run proves the PHY block, but not the Air's ports, retimers or port controller firmware.

What I checked: the property is read in exactly two places. atc.c:6905-6906 sets t8132_dp_alt from it. dcp_typec_route_no_dp_alt() (drivers/gpu/drm/apple/dcp-fabric.c:234) stops refusing the route once the PHY has it. Neither is a board check. The J604 uses the same property for its ATC0/1/3 ports. The dcpext routes, their disabled default and the tunnel path are unchanged. The merge onto integration is clean, and dt-checks and host-tests pass.

Nits:

  • atc.c:4821 still says "The T8132 PHY has no DisplayPort alternate mode", which is now false on three boards. Fix it here or in a follow-up.
  • Rewrap the two edited comment lines (j713-j715.dtsi :191, :243); they now pass 80 columns.

HW row: J713 on this head. On each USB-C port, a non-Thunderbolt USB-C monitor and a USB-C to HDMI adapter: mode set, hotplug out and in, and one s2idle with the display coming back. Then a USB4 display to confirm the tunnel path is unchanged. 0 AVC, 0 failed units, no new kernel errors.

Assisted-by: LLM (Claude:Opus 5.5)

@RyanTheTide

Copy link
Copy Markdown
Contributor Author

Replaced by #2807: the same changes with the commit trailers fixed, on the current integration/aurora.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant