Skip to content

arm64: dts: apple: t8132-laptop: describe the trackpad actuator on every M4 laptop - #2273

Open
RyanTheTide wants to merge 1 commit into
integration/aurorafrom
spec-m3m4/t8132-laptop-actuator
Open

RyanTheTide wants to merge 1 commit into
integration/aurorafrom
spec-m3m4/t8132-laptop-actuator

Conversation

@RyanTheTide

Copy link
Copy Markdown
Contributor

Problem. The MTP firmware on every M4 MacBook offers the trackpad's haptic engine as its "actuator" interface; the ADT has /arm-io/dockchannel-mtp/mtp-transport/actuator on the J604, J713 and J715. Only the J604's tree described it (#1886), so on the M4 MacBook Airs the click stays firmware-driven and there is no Force Touch stage.

Change. Describe the actuator in t8132-laptop.dtsi and drop the J604 copy.

Testing. cpp + dtc on all six T8132 boards: same warning counts. With phandles normalized:

  • J604, the iMacs and J773g: zero diff from the base.
  • J713 and J715: they gain only the actuator node.

Still to run. On a J713 or J715: hid-apple-mtp-haptic binds, and force click and haptic feedback work.

Assisted-by: LLM (Claude:Opus 5.5)

…ery M4 laptop

The MTP firmware on every M4 MacBook offers the trackpad's haptic engine
as its "actuator" interface (ADT /arm-io/dockchannel-mtp/mtp-transport/
actuator on the J604, J713 and J715). Only the J604's tree described it,
so on the MacBook Airs the click stays firmware-driven and there is no
Force Touch stage.

Describe it in the shared laptop file and drop the J604 copy. The J604
tree is unchanged; the J713 and J715 gain the actuator node.

Signed-off-by: Ryan <ryan@aurorasilicon.org>
@RyanTheTide

Copy link
Copy Markdown
Contributor Author

No blockers.

On current integration/aurora, J604, the iMacs and J773g are byte-identical, and J713/J715 gain only the empty actuator child under the MTP HID node. That is the node J604 has carried since #1886 (proven there: "Interface actuator is now ready", "initialised MTP haptics"), and the same node every other laptop family has. dockchannel-hid ignores an interface with no node, so before this the Airs never bound hid-apple-mtp-haptic. With no apple,click-strength, apple_taptic_set_click_strength() returns early, so the only new write is the mode reset at probe, and its failure is non-fatal. CI is green. Can leave draft.

HW row: J713 on the head: Interface actuator is now ready and the haptic driver bound, click and force click felt, 2x s2idle (rtc1 wake) with the click working after each; 0 AVC, 0 failed units, no new kernel errors.

Assisted-by: LLM (Claude:Opus 5.5)

@RyanTheTide

Copy link
Copy Markdown
Contributor Author

J713 row (M4 Air 13, macOS 27.2): the J713's default Stage 2 with only its DTB changed, adding the empty actuator child of the MTP HID node that this PR adds (the dts diff against the default DTB is that one node). Default kernel and default command line, aura-try one-shot.

  • dockchannel-hid 394b28000.input: Interface actuator is now ready, and hid-apple-mtp-haptic binds (hidraw2: ... [Apple MTP actuator]).
  • The existing udev rule for host-driven clicks sees the actuator node and switches the trackpad to host clicks: host-driven click feedback active on the first press. 16 presses were recorded during the window.
  • 0 failed units, 0 AVC denials, 0 oopses.

On the default without this node, the J713 has no actuator interface: dockchannel-hid ignores interfaces that have no DT node, so the click stays with the actuator's firmware. The J713 ADT has /arm-io/dockchannel-mtp/mtp-transport/actuator. The J615 (M3, which already describes it) behaves the same as this J713 boot.

Still to run: a J715 row, if one is available.

Assisted-by: LLM (Claude:Opus 5.5)

@RyanTheTide
RyanTheTide marked this pull request as ready for review November 22, 2026 05:12
@kazuhidet

Copy link
Copy Markdown

J715 row at 2108db4f (MacBook Air 15-inch, M4, Mac16,13), OS firmware 26.6.2, stage 1 → aura.

Build

Result: the driver binds. Force click is not felt, which matches the driver's default

  • /soc/fifo@394b14000/input@0/actuator is present.
  • The MTP firmware brings up the actuator interface ("Actuator initialized", "Actuator ready"), and dockchannel-hid reports "Interface actuator is now ready".
  • hid-apple-mtp-haptic binds as "Apple MTP actuator" on 394b28000.input.4. The firmware logs Intercepted 0x21 click handoff: 00, and magicmouse … initialised MTP haptics. lsmod shows hid_apple_mtp_haptic used by hid_magicmouse.
  • Felt: an ordinary click works. A deeper force click is not felt. hid-magicmouse's haptic_press was left at its default (off: the actuator's firmware plays the click), so host-played feedback, including the deep click, was not enabled in this run.
  • 0 DART faults.

Not covered:

  • haptic_press=1.
  • A comparison boot without the node.
  • s2idle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants