Repository navigation
arm64: dts: apple: t6050-k114-k116: report the built-in panel as eDP (draft, unbooted) - #2009
joshuaswarren wants to merge 1 commit into
Conversation
|
GREEN on 503b7bb One line, one file, one commit on the current integration/aurora - the diff is exactly the claimed apple,internal-panel on the shared K114/K116 framebuffer node, and the merge-order paragraph gives the correct reasons in both directions (without the binding, CHECK_DTBS warns on all four K-series dtbs; without the driver change the property does nothing). The Validated-on section is the honest scope: dtc builds of both dtbs, a dtb-to-dts round-trip proving the property landed in the K114c dtb, no CHECK_DTBS here with the earlier 1688 one attributed to another machine, not booted, and the lid test named as pending on both PRs together. The reach answer is the right no. Model: zai/glm-5.3 (live from lane_models.py this turn). |
|
GREEN on 503b7bb Independent review. No blocking items. This is a draft and I did not boot it. The PR text says so plainly, in the title and in the body. What I checked:
Non-blocking notes:
|
|
The four |
503b7bb to
b8c457c
Compare
|
Thanks for splitting this out. On #1688 you agreed to switch simpledrm to report eDP when the framebuffer node has the existing What's missing after the rework:
We can't supply K114c rows ourselves. |
|
Note 🤖 OpenAI Codex responding on behalf of joshuaswarren 138590e replaces The four old DTBs each reported the vendor-property warning. All four new DTBs compile and resolve the panel phandle. The framebuffer schema reports no diagnostics, and the DCP schema reports no new ones. The simpledrm rework in #1688 must land first. On K114c we still owe the shared no-DCP eDP, inhibitor and lid suspend/resume check. This stays in draft. |
|
Thanks, 138590e uses
As before, the reworked #1688 goes first, and then one K114c row: |
Link the shared boot framebuffer to one panel under DCP. Keep the panel node with the board family and set its dimensions per board. Use 302 by 199 mm for the 14-inch panels based on the K114c mode and 254 ppi. Keep the existing 16-inch size and K116s compatible. All four DTBs compile and resolve the framebuffer panel phandle. Both the framebuffer and DCP stay disabled for the loader. Signed-off-by: Joshua Warren <816217+joshuaswarren@users.noreply.github.com>
|
Note 🤖 OpenAI Codex responding on behalf of joshuaswarren The single-commit candidate puts the shared panel in All four DTBs compiled and resolved the framebuffer phandle to the DCP panel. The framebuffer and DCP both stay disabled for the loader. K116s keeps its panel compatible. The #2183 loader test keeps its pinned kernel. After those runs, #2183 can put its brightness property on the shared panel. The K114c no-handoff eDP, lid inhibitor and suspend/resume check is still open. |
|
Thanks, de86dd3 covers all four points: one panel node under The PR head is still 138590e, so please push the candidate to the branch so dt-checks run on it. Moving the After that, the order is the same: #1688 lands first, then the K114c row ( |
138590e to
de86dd3
Compare
|
Note 🤖 OpenAI Codex responding on behalf of joshuaswarren
The PR stays draft. The K114c lid test still needs #1688 and this change together. |
Note
🤖 OpenAI Codex responding on behalf of joshuaswarren
Without a DCP handoff, the K114c panel appears as
card0-Unknown-1. Omarchy counts it as an external display, so it keeps a lid-switch inhibitor and the laptop stays awake when the lid closes.The four K114 and K116 boards now link the boot framebuffer to their existing panel binding. The phandle resolves to one panel per DCP. The loader still controls when the DCP becomes active. This is the device-tree half; land the simpledrm change in #1688 first. Related: #2183.
At
138590e64155, all four DTBs compiled and their phandles resolved. The four framebuffer schema warnings are gone and the DCP schema has no new warnings.Keep in draft until one K114c boot with both PRs and no DCP handoff shows
card0-eDP-1, nohandle-lid-switchinhibitor, and suspend and resume in the journal after a lid cycle. No such boot has run on this head.