Repository navigation
drm/sysfb: report eDP for framebuffer panels - #1688
joshuaswarren wants to merge 2 commits into
Conversation
67e63a5 to
667f644
Compare
|
GREEN on 667f644 Checked the split against the diff and the body against both commits. The PR touches exactly the three claimed files - simpledrm.c, the J714c dts hunk carried inside commit 1, and the simple-framebuffer binding - with no K114/K116 dtsi present, matching the split-out claim. Commit 1's provenance is stated the right way: carried unchanged from omacom/linux-aurora (cherry-pick sha recorded), the J714c hunk rebased onto the current framebuffer node and disclosed, no Signed-off-by from ed claimed, and the J714c test result attributed to ed rather than restated as this PR's own validation. The Validated-on section keeps the same discipline: build-only on the M1 at this head, the CHECK_DTBS counts attributed to the earlier body on another machine and explicitly not repeated, the K114c eDP observation attributed to an earlier tree, and the lid test named as not run with its slot plan. The binding commit closes the CHECK_DTBS warning the property would otherwise raise - the right order given #2009 depends on it. Model: zai/glm-5.3 (live from lane_models.py this turn). |
|
GREEN on 667f644 Independent review. No blocking items. I did not boot anything, so the lid behaviour is not something I can confirm. What I checked:
What I could not run: a full Non-blocking notes:
|
667f644 to
4b92610
Compare
|
GREEN on 4b92610 Tree identity confirmed independently: both heads resolve to tree 4b96fb09bcfcb9438a4d31939cb6175439610dc1, the compare shows the binding commit rewritten with only the yaml in the reword, so nothing but the commit message changed. The reworded message and body attribute the evidence correctly for the split: the J714c node carries apple,internal-panel from the previous commit, the K114c/K114s/K116c/K116s nodes get it in #2009 which lands after, and the CHECK_DTBS numbers are attributed to an earlier form on another machine and not repeated at this head. My previous verdict on the code carries unchanged. Model: zai/glm-5.3 (live from lane_models.py this turn). |
|
GREEN on 4b92610 The tree is unchanged from my review of 667f644. Both heads have tree The reworded binding commit message is accurate. It says only the J714c node carries the property in the previous commit, and that the K114c, K114s, K116c and K116s nodes get it in a later device-tree change that fails CHECK_DTBS without this binding. I confirmed that last point earlier: a framebuffer node with Model: anthropic/claude-sonnet |
The K114c and K116c panel is a simpledrm framebuffer until DCP drives it, and its connector shows up as Unknown-1. Omarchy treats a connector that is not eDP, LVDS or DSI as an external monitor and holds a block inhibitor on handle-lid-switch, so closing the lid never suspends. aurora-silicon/linux aurora-silicon#1688 makes simpledrm report eDP for a framebuffer node that carries apple,internal-panel. Put the property on the shared K114/K116 framebuffer node, as the J714c node already has it. Compile check only: the K114c dtb builds and dtc shows the property on framebuffer@0; simpledrm.o builds. Not booted on a K114c yet. Signed-off-by: Joshua Warren <816217+joshuaswarren@users.noreply.github.com>
|
Thanks for splitting this out, and to ed for the original. One design point. The binding already has a Could simpledrm report eDP when the framebuffer node has a ed's Signed-off-by on the first commit is needed before merge. Row: K114c or J714c booted without the DCP handoff. After that, we can run a no-regression row on our M1 Pro. |
|
[Joshua's agent] The design point is right and we will rework the PR along those lines: report eDP when the framebuffer node carries the One dependency shapes the order: the phandle needs a panel node to point at. The panel nodes are still open (#2183 for the K114c panel, the K114/K116 set in #2009), so the rework stacks behind them. The driver change itself (phandle implies eDP) is independent and lands with the rework. ed's Signed-off-by will be on the carried commit before merge - we will ask him to confirm it (here or in the team chat), not add it on his behalf. The requested row (booted without the DCP handoff: |
|
Thanks for taking the
Once that is up, we will run a no-regression row on our M1 Pro, which already has |
|
Note 🤖 OpenAI Codex responding on behalf of joshuaswarren e65fe26 makes simpledrm report eDP when the existing The J714c DTB resolves The no-DCP eDP and lid row, and ed's own sign-off, remain open. The M1 Pro regression row can follow when the same head is ready. |
|
Thanks, e65fe26 is the shape we hoped for. simpledrm reports eDP when the Before review:
This changes the connector type on every Apple laptop tree with |
Report eDP when the framebuffer node points to a panel. Leave the connector type unchanged when the panel phandle does not resolve. Signed-off-by: Joshua Warren <816217+joshuaswarren@users.noreply.github.com>
e65fe26 to
02d7b6c
Compare
|
Thanks, 8da6768 and 02d7b6c are the clean two-commit history we asked for, and the title and body match. Two small things:
Still owed, as you say: the no-DCP-handoff row with |
|
Note 🤖 OpenAI Codex responding on behalf of joshuaswarren The J714c panel now sits under I'll add the |
|
Thanks, b1cb83a puts the J714c panel under One small thing: b1cb83a only moves the node that 02d7b6c added. Please fold it into 02d7b6c when you add the Nothing else from us at this head. As you say, the no-handoff hardware row is still owed ( |
Link the boot framebuffer to the panel under DCP. Keep the panel in one place so the boot framebuffer and a later DCP handoff can use the same description. The dimensions come from J714s. Signed-off-by: Joshua Warren <816217+joshuaswarren@users.noreply.github.com>
b1cb83a to
971e41f
Compare
|
Note 🤖 OpenAI Codex responding on behalf of joshuaswarren
I’ll add the |
When the boot framebuffer points to an internal panel, simpledrm reports an eDP connector. A framebuffer without a resolved
panelphandle keeps the Unknown connector type.The J714c framebuffer links to the panel with the existing
panelbinding. The loader still enables the framebuffer. The 302 by 196 mm size comes from J714s and is unconfirmed on J714c.The two-commit candidate has the same file contents as CI-green head
e65fe2640c72. It drops the historical vendor-property commits.The no-DCP handoff row is still open:
card0-eDP-1, nohandle-lid-switchinhibitor, and suspend and resume in the journal. The M1 Pro and M2 regression rows follow that check.