Repository navigation
arm64: dts: apple: t6050-j714c: Trackpad reset, SMC sensors and keyboard backlight - #1984
Open
XY55bqg6iAw8ttP wants to merge 3 commits into
Open
XY55bqg6iAw8ttP wants to merge 3 commits into
XY55bqg6iAw8ttP wants to merge 3 commits into
Conversation
With apple,firmware-managed-reset the MTP firmware is left to reset the
trackpad's AFE, and on the J714c it never does: the AFE never boots
("AFE[0] Chip Boot Failure for HBPP: No HINT_L") and the multi-touch
interface times out, so the trackpad is dead.
The J714cAP ADT gives dockchannel-mtp/mtp-transport/multi-touch a
function-afe-reset of the SMC pcIO template (0x10000, 0x11c0000), the
same line as on the J714s: SMC GPIO gp1c, active low. Describe it as
apple,afe-reset-gpios on mtp_hid, as the J714s does, and drop
apple,firmware-managed-reset.
Tested on a J714c: the host sends the AFE image, the multi-touch
interface comes up and the trackpad works. The other ten T6050 board
DTBs are byte-identical.
Assisted-by: LLM
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: XY55bqg6iAw8ttP <132220364+XY55bqg6iAw8ttP@users.noreply.github.com>
…ture sensors The J714c left smc_hwmon disabled until its fan and power keys were checked. The J714cAP SMC has the J714s's keys: two fans, F0Ac and F1Ac, 2317 to 7826 rpm, with the T6050 mode keys F0md and F1md, and the shared power, voltage and current keys. Use the J714s block: the common, dual fan and laptop sensors, temperature discovery, and the shared temperature nodes and apple,soc-die-keys removed so discovery runs. Tested on a J714c: macsmc_hwmon reports both fans, 342 temperature keys and the system, AC input and heatpipe power. The other ten T6050 board DTBs are byte-identical. Assisted-by: LLM Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: XY55bqg6iAw8ttP <132220364+XY55bqg6iAw8ttP@users.noreply.github.com>
The J714cAP ADT has arm-io/pwm0, an fpwm s5l8920x at 0x3_05040000 (0x5_05040000 here, fpwm0 in the T6050 inventory), with a kbd-backlight child at default-hz 25000. Describe it as the J714s does: a pwm-leds kbd_backlight on fpwm0 channel 0 with a 40000 ns period, and enable fpwm0. Tested on a J714c: kbd_backlight appears with max brightness 255, the PWM follows the brightness (20 us of 40 us at 128) and the keys light. The other ten T6050 board DTBs are byte-identical. Assisted-by: LLM Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: XY55bqg6iAw8ttP <132220364+XY55bqg6iAw8ttP@users.noreply.github.com>
This was referenced Nov 19, 2026
Contributor
|
@XY55bqg6iAw8ttP, thanks for the J714c work here. Beyond this PR, two J714c rows would help:
dmesg plus the command output, here or in a new issue, is perfect. |
Contributor
|
As promised, the branch that widens SIO and the PMP CoreAnalytics acknowledgement from the J714s to every T6050 board (keyed on the hardware instead of the board name) is #2412 (draft). A boot of it plus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small fixes for the 14-inch M5 Max (J714c), all in
t6050-j714c.dts. Each one copies what the J714s already does, with the values checked against a J714cAP ADT (macOS 27.3 beta 1, 26C5035r). The other ten T6050 board DTBs are byte-identical after each commit.What changes
apple,firmware-managed-resetleaves the AFE reset to the MTP firmware, which never does it on this board:AFE[0] Chip Boot Failure for HBPP: No HINT_L, theniface multi-touch start timed out. The trackpad is dead.apple,afe-reset-gpios = <&smc_gpio_low 28 GPIO_ACTIVE_LOW>onmtp_hid, as on the J714s, and dropapple,firmware-managed-reset.&smc_hwmonis disabled ("fan and power keys are not yet checked"), so no fan, power or temperature readings.hwmon-common,hwmon-fan-dual,hwmon-laptop, fan mode keysF0md/F1md, temperature discovery.kbd_backlightLED.pwm-ledsonfpwm0channel 0, 40000 ns, as on the J714s.Where the values come from (J714cAP ADT)
dockchannel-mtp/mtp-transport/multi-touchfunction-afe-reset=[0x293 'pIcp' 0x10000 0x11c0000], the same SMC pcIO template as the J714s, so SMC GPIO gp1c (28), active low.F0Ac/F1Ac, 2317 to 7826 rpm; the SMC drives them.arm-io/pwm0isfpwm,s5l8920xatreg 0x5040000 0x3(0x5_05040000 in the DT, the same arm-io offset as the GPU),pwm0/kbd-backlightdefault-hz= 25000, so a 40000 ns period.Tested
On a J714c (Mac17,7, M5 Max), macOS 27.3 beta 1 firmware, kernel 7.3.0-k114c, with the DTB built from this branch:
New AFE[0] cbor image received, thenInterface multi-touch is now ready, and the pointer moves.macsmc_hwmon: two fans, 342 discovered temperature keys, Total System Power, AC input and heatpipe power./sys/class/leds/kbd_backlight: max 255; at 128 the PWM runs 20 us / 40 us and the keys light. systemd-backlight restores the level at boot.The same three changes also ran for a day as an overlay on Warren's
k114c-m5max-kernelJ714c DT.🤖 Generated with Claude Code