Repository navigation
arm64: dts: apple: t6050: share the keyboard backlight, add it to J716c - #2282
Draft
RyanTheTide wants to merge 1 commit into
Draft
RyanTheTide wants to merge 1 commit into
RyanTheTide wants to merge 1 commit into
Conversation
The J716c leaves fpwm0 disabled and has no keyboard backlight LED. Its ADT has the same pwm0 kbd-backlight node as the J714s, J716s and the K114/K116 boards: channel 0 of fpwm0 at 25 kHz. Move the pwm-leds node and the fpwm0 enable, which the J714s and J716s each carried as an identical copy, into a new t6050-kbd-backlight.dtsi. Include it from the J714s, J716s, J716c and t6050-k114-k116.dtsi. The K boards keep their own LED label and no default-state through a small override, and keep their rear logo LED in the same controller. The J716c gains the LED and an enabled fpwm0. The J714s, J716s, K114c, K114s, K116c and K116s DTBs are byte-identical; no other T6050 board changes. The J714c can take the same include. The J714s block was added by DjDeveloperr, the J716s one by Rolando Trevino. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
Contributor
Author
|
No blockers. Rebuilt every T6050 DTB on current integration/aurora: only J716c changes, gaining the pwm-leds node and
HW row: J716c on the head: Assisted-by: LLM (Claude:Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The J716c has no keyboard backlight.
t6050-j716c.dtsleaves fpwm0 disabled and has no pwm-leds node. Its ADT has the same pwm0 kbd-backlight node as the J714s, the J716s and the K114/K116 boards: channel 0 of fpwm0 at 25 kHz.The J714s and J716s carry identical copies of the LED block. The K boards have their own copy, with a different label.
Change
t6050-kbd-backlight.dtsi: the pwm-leds node (pwms = <&fpwm0 0 40000>, labelkbd_backlight,default-state = "keep") and&fpwm0 { status = "okay"; }.t6050-j714s.dts,t6050-j716s.dts: the copy is replaced by the include.t6050-k114-k116.dtsi: includes the file. A small override keeps the existingapple::kbd_backlightlabel and dropsdefault-state, so the K boards' DTBs do not change. The rear logo LED stays in the same controller.t6050-j716c.dts: includes the file. This is the only functional change.J714c: #1984 adds the same LED block to
t6050-j714c.dts, with the same label, default-state and period. It can rebase onto this PR and use#include "t6050-kbd-backlight.dtsi"instead. This PR does not touch J714c.Testing
make dtbs CHECK_DTBS=y(dtschema) for every T6050 DTB on this branch: builds clean, no dtc warnings, and no schema message that integration/aurora does not already have.Still to run
brightnessctl -d kbd_backlight set 50%lights the keys. The level is the same after an s2idle cycle.No loader change is needed. It does not depend on #2208/#2209. Those touch other nodes in
t6050-j716c.dts, so a rebase there is trivial.Per-board values and DTB diffs
Values come from each board's ADT: pwm0 kbd-backlight, channel 0, 25 kHz, so a 40000 ns period. This is the same on J714c, J714s, J716c, J716s and K116s (checked in each board's ADT) and on the other K boards (already described that way).
J716c, decompiled DTB, phandle renumbering masked:
All other boards: byte-identical DTB.
Assisted-by: LLM (Claude:Opus 5.5)