Skip to content

fix(deps, ci): bump setup-sbt and playwright - #9100

Merged
parshimers merged 4 commits into
apache:mainfrom
aglinxinyuan:fix/ci-unblock-merge-queue
Oct 23, 2026
Merged

parshimers merged 4 commits into
apache:mainfrom
aglinxinyuan:fix/ci-unblock-merge-queue

Conversation

@aglinxinyuan

@aglinxinyuan aglinxinyuan commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Nothing can merge into main right now. Three CI faults block it, and each fix needs the others to land first.

Before:  Scala job     -> sbt/setup-sbt v1.5.7  -> nested carabiner action not allowed -> fails at Set up job
         frontend job  -> ubuntu-26.04 runner   -> Playwright 1.59.1 has no Chromium    -> fails at install
         merge group   -> no runner within 45 min                -> checks_timed_out, PR leaves the queue
After:   Scala job     -> sbt/setup-sbt v1.5.12 -> every nested action allowed         -> runs
         frontend job  -> ubuntu-26.04 runner   -> Playwright 1.64.1 installs Chromium  -> runs
         merge group   -> waits up to 360 min for runners         -> merges
  • setup-sbt. The ASF actions allowlist dropped the nested carabiner-dev/actions/install/* refs that sbt/setup-sbt v1.5.7 reaches, so every job that sets up sbt (amber, amber-integration, platform, platform-integration, Bench) has died at Set up job since 2026-10-19. This moves all 9 call sites to v1.5.12, whose whole chain is allowed. The action's inputs did not change.
  • Playwright. ubuntu-latest now resolves to the Ubuntu 26.04 image, where Playwright 1.59.1 refuses to install Chromium ("Playwright does not support chromium on ubuntu26.04-x64"), so the ubuntu frontend leg fails before any test runs. This bumps playwright to 1.64.1, which supports 26.04.
  • Merge queue timeout. The queue ejects an entry whose required checks have not reported within check_response_timeout_minutes, which is 45. ASF's shared runners are backed up well past that: in the last merge group, Validate PR title, a 2-second job, waited 110 minutes for a runner. This raises the limit to 360 minutes, as DataFusion did in ci: raise the merge queue status check timeout to 360 minutes datafusion#26293.

Required Checks stays red without both version bumps, and no PR gets through the queue without the higher limit, so all three go in one PR.

Any related issues, documentation, discussions?

Closes #9095.

How was this PR tested?

Every changed file parses:

python -I -c "import sys, yaml; [yaml.safe_load(open(f)) for f in sys.argv[1:]]" .asf.yaml .github/workflows/benchmarks.yml .github/workflows/build-and-push-images.yml .github/workflows/build.yml .github/workflows/dependency-graph.yml

Walking the uses: chain under sbt/setup-sbt@ecad189 (v1.5.12) reaches ampel/verify@32587e8, install/ampel@d6d91c5, install/download-and-verify@2fec8bd and install/ampel-bootstrap@16009dc, and all four are in apache/infrastructure-actions' approved_patterns.yml as of 2026-10-23. Under v1.5.7, install/ampel@2fec8bd, install/download-and-verify@16009dc and install/ampel-bootstrap@619a474 are not.

The rest is CI. The labeler applies ci for .github/**, which runs every stack that sets up sbt, the frontend legs, and Bench. On this PR's previous head every job passed except the ubuntu frontend leg, which landed on ubuntu-26.04 and failed at the Playwright install. The new timeout only shows once this is merged.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5.5)

🤖 Generated with Claude Code

aglinxinyuan and others added 2 commits October 22, 2026 22:56
The ASF actions allowlist dropped the transitive carabiner-dev refs
(install/ampel, download-and-verify, ampel-bootstrap) that
setup-sbt v1.5.7 resolves through, so every job using it fails at
"Set up job". v1.5.12 resolves through refs that are all on the
current allowlist; its inputs are unchanged. Bump all 9 call sites.
If this limit is too low, the merge queue can enter a starvation
loop where every job times out if runners are simply busy. Raising
the limit stops this.
Copilot AI balanced review requested due to automatic review settings October 23, 2026 06:01
@aglinxinyuan aglinxinyuan added the release/v1.3 back porting to release/v1.3 label Oct 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chenlica chenlica left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added fix ci changes related to CI labels Oct 23, 2026
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @aicam, @kz930, @renovate-bot
    You can notify them by mentioning @aicam, @kz930, @renovate-bot in a comment.

@aglinxinyuan
aglinxinyuan disabled auto-merge October 23, 2026 07:54
@aglinxinyuan aglinxinyuan added emergency Pull requests that need to be merged ASAP and removed release/v1.3 back porting to release/v1.3 labels Oct 23, 2026
@codecov-commenter

codecov-commenter commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.33%. Comparing base (2407d79) to head (5213394).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9100   +/-   ##
=========================================
  Coverage     92.33%   92.33%           
- Complexity     5045     5046    +1     
=========================================
  Files          1261     1261           
  Lines         54120    54120           
  Branches       6768     6768           
=========================================
  Hits          49974    49974           
+ Misses         2486     2485    -1     
- Partials       1660     1661    +1     
Flag Coverage Δ
access-control-service 77.38% <ø> (ø)
agent-service 99.16% <ø> (ø)
amber 87.33% <ø> (+0.01%) ⬆️
computing-unit-managing-service 60.48% <ø> (ø)
config-service 87.37% <ø> (ø)
file-service 82.00% <ø> (ø)
frontend 96.54% <ø> (-0.02%) ⬇️
notebook-migration-service 83.73% <ø> (ø)
pyamber 98.57% <ø> (ø)
workflow-compiling-service 72.43% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ubuntu-latest runners are moving to the Ubuntu 26.04 image, where
playwright 1.59.1 refuses to install Chromium ("Playwright does not
support chromium on ubuntu26.04-x64"), so the ubuntu frontend leg
fails before any test runs. 1.61.0 is the first release that knows
ubuntu26.04; bump to the current 1.64.1 and regenerate yarn.lock.
@aglinxinyuan aglinxinyuan changed the title fix(deps, ci): bump sbt/setup-sbt to v1.5.12 and raise the merge queue timeout fix(deps, ci): bump setup-sbt and playwright, raise the merge queue timeout Oct 23, 2026
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

✅ No material benchmark regressions detected

🟢 9 better · 🔴 0 worse · ⚪ 6 noise (<±5%) · 0 without baseline

Compared against main 2407d79 benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

config throughput MB/s latency max Δ latest / 7d
🟢 bs=10 sw=10 sl=64 683 0.417 13,999/20,106/20,106 us 🟢 -20.7% / 🔴 +42.4%
🟢 bs=100 sw=10 sl=64 1,678 1.024 58,496/69,411/69,411 us 🟢 -32.3% / 🟢 -36.1%
⚪ bs=1000 sw=10 sl=64 2,048 1.25 486,761/530,636/530,636 us ⚪ within ±5% / 🟢 +55.0%
Baseline details

Latest main 2407d79 from same runner

config metric PR latest main 7d avg Δ latest Δ 7d
bs=10 sw=10 sl=64 throughput 683 tuples/sec 593 tuples/sec 968.33 tuples/sec +15.2% -29.5%
bs=10 sw=10 sl=64 MB/s 0.417 MB/s 0.362 MB/s 0.591 MB/s +15.2% -29.4%
bs=10 sw=10 sl=64 p50 13,999 us 16,854 us 10,646 us -16.9% +31.5%
bs=10 sw=10 sl=64 p95 20,106 us 25,356 us 14,120 us -20.7% +42.4%
bs=10 sw=10 sl=64 p99 20,106 us 25,356 us 16,498 us -20.7% +21.9%
bs=100 sw=10 sl=64 throughput 1,678 tuples/sec 1,563 tuples/sec 1,252 tuples/sec +7.4% +34.0%
bs=100 sw=10 sl=64 MB/s 1.024 MB/s 0.954 MB/s 0.764 MB/s +7.3% +34.0%
bs=100 sw=10 sl=64 p50 58,496 us 59,421 us 83,736 us -1.6% -30.1%
bs=100 sw=10 sl=64 p95 69,411 us 102,547 us 92,464 us -32.3% -24.9%
bs=100 sw=10 sl=64 p99 69,411 us 102,547 us 108,561 us -32.3% -36.1%
bs=1000 sw=10 sl=64 throughput 2,048 tuples/sec 2,025 tuples/sec 1,321 tuples/sec +1.1% +55.0%
bs=1000 sw=10 sl=64 MB/s 1.25 MB/s 1.236 MB/s 0.806 MB/s +1.1% +55.0%
bs=1000 sw=10 sl=64 p50 486,761 us 490,197 us 811,260 us -0.7% -40.0%
bs=1000 sw=10 sl=64 p95 530,636 us 547,825 us 847,636 us -3.1% -37.4%
bs=1000 sw=10 sl=64 p99 530,636 us 547,825 us 879,277 us -3.1% -39.7%
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,292.87,200,128000,683,0.417,13998.52,20105.87,20105.87
1,100,10,64,20,1191.98,2000,1280000,1678,1.024,58496.18,69410.71,69410.71
2,1000,10,64,20,9766.63,20000,12800000,2048,1.250,486761.22,530636.08,530636.08

@github-actions github-actions Bot added dependencies Pull requests that update a dependency file frontend Changes related to the frontend GUI labels Oct 23, 2026
@aglinxinyuan
aglinxinyuan disabled auto-merge October 23, 2026 20:06
@aglinxinyuan

Copy link
Copy Markdown
Contributor Author

Original timeout PR is merged, so we don't need this PR anymore.

@parshimers parshimers reopened this Oct 23, 2026
@parshimers
parshimers enabled auto-merge October 23, 2026 22:17
@parshimers

Copy link
Copy Markdown
Member

If everything works out, we'll wake up tomorrow with a clean queue and this merged 🫠

@Yicong-Huang Yicong-Huang changed the title fix(deps, ci): bump setup-sbt and playwright, raise the merge queue timeout fix(deps, ci): bump setup-sbt and playwright Oct 23, 2026
@parshimers
parshimers added this pull request to the merge queue Oct 23, 2026
Merged via the queue into apache:main with commit 3b39b75 Oct 23, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI dependencies Pull requests that update a dependency file emergency Pull requests that need to be merged ASAP fix frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raise the merge queue check response timeout

5 participants